REF: simplify DTI._parse_string_to_bounds #31519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
requested changes
Feb 1, 2020
pandas/_libs/tslibs/period.pyx
Outdated
| @@ -1186,6 +1186,13 @@ cdef int64_t period_ordinal_to_dt64(int64_t ordinal, int freq) except? -1: | |||
| if ordinal == NPY_NAT: | |||
| return NPY_NAT | |||
|
|
|||
| if freq == 11000: | |||
| # Microsecond, avoid get_date_info to prevent floating point errors | |||
| pandas_datetime_to_datetimestruct(ordinal, NPY_FR_us, &dts) | |||
There was a problem hiding this comment.
unrelated but have you ever thought about renaming this function to something like "int64ns_to_datetimestruct"? I always find myself thinking about what a "pandas_datetime" is
There was a problem hiding this comment.
i generally agree. i think it got this name because the numpy version is numpy_datetime_to_datetimestruct or something along those lines.
| assert start == expected | ||
| assert start.value == per.ordinal * 1000 | ||
|
|
||
| per2 = Period("2300-01-01", "us") |
There was a problem hiding this comment.
Can you split this off into a separate _raises test?
jbrockmendel
changed the title
jbrockmendel
added
the
Indexing
…rsed_string_to_bounds
…rsed_string_to_bounds
|
nice, really simplfies |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sits on top of #31475. i.e. once that is merged, the only diff remaining here will be in indexes.datetimes.
After this, we are within striking distance of sharing the method between DTI/PI.