-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
BUG: Fixed IntervalArray[int].shift #31502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Fixed IntervalArray[int].shift #31502
Conversation
cc @jschendel for thoughts on that. |
This is still failing for |
The datetime64 failure is present on master. I've opened #31504 for it. |
LGTM, agreed it would be nice to find a way to make this work in the general case. |
All green now. Sorry about the string of CI failures earlier. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks
Co-Authored-By: Joris Van den Bossche <[email protected]>
Co-authored-by: Tom Augspurger <[email protected]>
Closes #31495
In ExtensionArray.shift, we have the note
I wonder, should we have a method / property like
And for IntervalArray, we would do something like
That would let us deduplicate things, since the call to
_from_sequence
would know to not passdtype=self.dtype
and trigger a re-inference.