ENH: Implement DataFrame.value_counts #31247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
requested changes
Jan 24, 2020
Co-Authored-By: William Ayd <[email protected]>
Co-Authored-By: William Ayd <[email protected]>
jreback
requested changes
Jan 26, 2020
pandas/core/frame.py
Outdated
| if subset is None: | ||
| subset = self.columns.tolist() | ||
|
|
||
| # Some features not supported yet |
There was a problem hiding this comment.
i would remove these args then
added 8 commits
January 26, 2020 00:51
jreback
requested changes
Feb 9, 2020
pandas/core/frame.py
Outdated
|
|
||
| .. versionadded:: 1.1.0 | ||
|
|
||
| The returned Series will have a MultiIndex with one level per input |
|
also pls merge master |
jreback
requested changes
Feb 23, 2020
| @@ -0,0 +1,102 @@ | |||
| import numpy as np | |||
|
|
|||
| import pandas as pd | |||
There was a problem hiding this comment.
move to the methods/ subdir
|
Getting some seemingly unrelated test failures from |
|
@jreback Green after the CI fixes, thanks for the review |
jreback
approved these changes
Feb 26, 2020
|
thanks @dsaxton very nice! |
roberthdevries
pushed a commit
to roberthdevries/pandas
that referenced
this pull request
Mar 2, 2020
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasThis is picking up where #27350 left off because I think it'd be a nice feature to have. At least one thing that still needs to be done is implementing
binswhen we have only a single column insubset, in which case maybe we can just delegate toSeries.value_counts.