Skip to content

DOC: Add pandas_path to the accesor list in the documentation #30898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 16, 2020
Merged

DOC: Add pandas_path to the accesor list in the documentation #30898

merged 3 commits into from
Jan 16, 2020

Conversation

pjbull
Copy link
Contributor

@pjbull pjbull commented Jan 10, 2020

Added the pandas_path package that I just released to the list of third-party accessor extensions.

As a bonus, added a Description column for the existing libraries.

WillAyd
WillAyd approved these changes Jan 10, 2020
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm @datapythonista

@WillAyd WillAyd added the Docs label Jan 10, 2020
datapythonista
datapythonista approved these changes Jan 11, 2020
View reviewed changes
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice extension. Besides adding it to the table of acessors, doesn't it make sense to have a longer description in one of the other sections?

@pjbull
Copy link
Contributor Author

pjbull commented Jan 11, 2020

@datapythonista Cool, I added a longer description to the "Data cleaning" section, which seemed the most relevant. That make sense?

datapythonista
datapythonista approved these changes Jan 13, 2020
View reviewed changes
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @pjbull

@WillAyd WillAyd added this to the 1.1 milestone Jan 16, 2020
@WillAyd WillAyd merged commit 208bb41 into pandas-dev:master Jan 16, 2020
@WillAyd
Copy link
Member

WillAyd commented Jan 16, 2020

Thanks @pjbull

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

@datapythonista datapythonista datapythonista approved these changes

Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@pjbull @WillAyd @datapythonista