Skip to content

TYP: check_untyped_defs astype_nansafe #30548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 30, 2019
Merged

TYP: check_untyped_defs astype_nansafe #30548

merged 1 commit into from
Dec 30, 2019

Conversation

simonjayhawkins
Copy link
Member 

pandas\core\arrays\integer.py:549: error: Argument "copy" to "astype_nansafe" has incompatible type "None"; expected "bool"
pandas\core\arrays\boolean.py:527: error: Argument "copy" to "astype_nansafe" has incompatible type "None"; expected "bool"

@simonjayhawkins simonjayhawkins added the Typing type annotations, mypy/pyright type checking label Dec 29, 2019
@simonjayhawkins simonjayhawkins added this to the 1.0 milestone Dec 29, 2019
@jbrockmendel
Copy link
Member

LGTM

@jreback jreback merged commit af84f45 into pandas-dev:master Dec 30, 2019
@jreback
Copy link
Contributor

jreback commented Dec 30, 2019

thanks

@simonjayhawkins simonjayhawkins deleted the astype_nansafe branch December 30, 2019 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@simonjayhawkins @jbrockmendel @jreback