DEPR: tz-aware Series/DatetimIndex.__array__ returns an object array of Timestamps #30516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Deprecate
added 2 commits
December 27, 2019 11:32
|
IIRC the places where i see this warning are in xarray and matplotlib tests. should we check with them to make sure they're ready for this? cc @shoyer @tacaswell |
|
closes #24716? |
|
Yup, looks like it. |
|
I guess waiting on xarray / mpl, can you open an issue on each of those trackers. |
Closed
|
Does/should this affect |
|
FWIW, I don't think we need to wait on xarray or matplotlib. These are warnings that should be seen by the user, and they have actions they can take already to avoid them. |
TomAugspurger
approved these changes
Jan 2, 2020
|
+1 for xarray -- this is something that users can already deal with as
needed
…On Thu, Jan 2, 2020 at 9:47 AM Tom Augspurger ***@***.***> wrote:
***@***.**** approved this pull request.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#30516?email_source=notifications&email_token=AAJJFVRGXQX7FVU2XOA6TNTQ3YSEFA5CNFSM4KAAXYKKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCQRAQWY#pullrequestreview-337774683>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJJFVSCRWSRBM6DSSDSSBDQ3YSEFANCNFSM4KAAXYKA>
.
|
|
thanks @mroeschke |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff