TST: add test for df construction from dict with tuples #29497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
requested changes
Nov 9, 2019
| [([("a",), ("a",)], [1, 2]), ([("a",), ("b",)], [1, 2]), ([("a", "b")], [1])], | ||
| ) | ||
| def test_constructor_from_dict_tuples(self, keys, values): | ||
| data_dict = {key: value for key, value in zip(keys, values)} |
There was a problem hiding this comment.
Can you just parametrize dictionaries directly instead of doing this?
There was a problem hiding this comment.
Thanks @WillAyd - incorporated the change.
WillAyd
requested changes
Nov 9, 2019
| df = DataFrame.from_dict(data_dict) | ||
|
|
||
| result = df.columns | ||
| all_columns = [key for sub_dict in data_dict for key in sub_dict.keys()] |
There was a problem hiding this comment.
You can just parametrize the expected column values alongside the data instead of doing this
WillAyd
approved these changes
Nov 9, 2019
|
Thanks @ganevgv! |
keechongtan
added a commit
to keechongtan/pandas
that referenced
this pull request
Nov 11, 2019
…ndexing-1row-df * upstream/master: (109 commits) stronger typing in libreduction (pandas-dev#29502) API: rename labels to codes (pandas-dev#29509) CLN: remove unnecessary type checks (pandas-dev#29517) implement _BaseGrouper (pandas-dev#29520) CLN: F-string formatting in pandas/_libs/*.pyx (pandas-dev#29527) Fixed more SS03 errors (pandas-dev#29540) consolidate dim checks (pandas-dev#29536) REF: separate out _get_cython_func_and_vals (pandas-dev#29537) remove unnecessary exception (pandas-dev#29538) TST:Add test to check single category col returns series with single row slice (pandas-dev#29521) Make color validation more forgiving (pandas-dev#29122) DOC: update bottleneck repo and documentation urls (pandas-dev#29516) TST: add test for df construction from dict with tuples (pandas-dev#29497) add test for pd.melt dtypes preservation (pandas-dev#29510) updated DataFrame.equals docstring (pandas-dev#29496) Resolved merge conflicts (pandas-dev#29506) DOC: Improved pandas/compact/__init__.py (pandas-dev#29507) DOC: Update performance comparison section of io docs (pandas-dev#28890) TST: add test for df.where() with category dtype (pandas-dev#29454) DOC: Fix docs on merging categoricals. (pandas-dev#28185) ...
Reksbril
pushed a commit
to Reksbril/pandas
that referenced
this pull request
Nov 18, 2019
…9497) * add test for frame construction from dict with tuples * parametrize full data_dict * refactor parametrize
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
…9497) * add test for frame construction from dict with tuples * parametrize full data_dict * refactor parametrize
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
…9497) * add test for frame construction from dict with tuples * parametrize full data_dict * refactor parametrize
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff