Skip to content

TYPING: errors reported by mypy 0.730 #28910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 11, 2019
Merged

TYPING: errors reported by mypy 0.730 #28910

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c21292e
TYPING: errors reported by mypy 0.730
simonjayhawkins Oct 10, 2019
240dee5
fix comment
simonjayhawkins Oct 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions pandas/compat/pickle_compat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,11 @@ def load_reduce(self):

class _LoadSparseSeries:
# To load a SparseSeries as a Series[Sparse]
def __new__(cls) -> "Series":

# https://github.com/python/mypy/issues/1020
# error: Incompatible return type for "__new__" (returns "Series", but must return
# a subtype of "_LoadSparseSeries")
def __new__(cls) -> "Series": # type: ignore
from pandas import Series

warnings.warn(
Expand All @@ -82,7 +86,11 @@ def __new__(cls) -> "Series":

class _LoadSparseFrame:
# To load a SparseDataFrame as a DataFrame[Sparse]
def __new__(cls) -> "DataFrame":

# https://github.com/python/mypy/issues/1020
# error: Incompatible return type for "__new__" (returns "DataFrame", but must
# return a subtype of "_LoadSparseFrame")
def __new__(cls) -> "DataFrame": # type: ignore
from pandas import DataFrame

warnings.warn(
Expand Down