Skip to content

CLN: Remove python2-style longs in regexes #26337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2019

Conversation

topper-123
Copy link
Contributor

Minor cleanup: Cleanup some regexes that guard against python2 style longs in their error messages.

@codecov
Copy link

codecov bot commented May 10, 2019

Codecov Report

Merging #26337 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26337      +/-   ##
==========================================
- Coverage   92.04%   92.03%   -0.01%     
==========================================
  Files         175      175              
  Lines       52297    52297              
==========================================
- Hits        48137    48133       -4     
- Misses       4160     4164       +4
Flag Coverage Δ
#multiple 90.59% <ø> (ø) ⬆️
#single 40.72% <ø> (-0.15%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 97.01% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee6b131...1fb577d. Read the comment docs.

@codecov
Copy link

codecov bot commented May 10, 2019

Codecov Report

Merging #26337 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26337      +/-   ##
==========================================
- Coverage   92.04%   92.03%   -0.01%     
==========================================
  Files         175      175              
  Lines       52292    52292              
==========================================
- Hits        48132    48128       -4     
- Misses       4160     4164       +4
Flag Coverage Δ
#multiple 90.59% <ø> (ø) ⬆️
#single 40.71% <ø> (-0.15%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 97.01% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 681a22c...42e7301. Read the comment docs.

@topper-123
Copy link
Contributor Author

The failures are unrelated:

Exception: Cython-generated file 'pandas\_libs/algos.c' not found.
                    Cython is required to compile pandas from a development branch.
                    Please install Cython or download a release package of pandas

@gfyoung
Copy link
Member

gfyoung commented May 10, 2019

@topper-123 : The issue actually traces to conda being unable to create the pandas-dev environment that we use for testing:

https://dev.azure.com/pandas-dev/pandas/_build/results?buildId=11274 (this is for your PR)

Not sure why Windows is not liking the YAML. It hasn't been touched since end of March.

@topper-123
Copy link
Contributor Author

Ok, I'll push again, maybe it was something intermittent on the servers.

@topper-123 topper-123 force-pushed the remove_py2_rexex_longs branch from 1fb577d to ebc80c7 Compare May 10, 2019 22:14
@topper-123
Copy link
Contributor Author

No, already failed. Strange...

@jreback jreback added this to the 0.25.0 milestone May 11, 2019
@jreback
Copy link
Contributor

jreback commented May 11, 2019

looks ok; waiting on resolution of CI issues.

@topper-123 topper-123 force-pushed the remove_py2_rexex_longs branch from ebc80c7 to 42e7301 Compare May 12, 2019 12:20
@topper-123
Copy link
Contributor Author

This passes now.

@jreback jreback merged commit 8e62539 into pandas-dev:master May 12, 2019
@jreback
Copy link
Contributor

jreback commented May 12, 2019

thanks @topper-123

@topper-123 topper-123 deleted the remove_py2_rexex_longs branch May 12, 2019 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants