CLN: Fixturize test_base.py

[nixphix]

Partially Fixes #23877

• tests added / passed
• passes git diff upstream/master -u -- "*.py" | flake8 --diff
• whatsnew entry

@jreback Could you please review the fixtures, I haven't replaced all the indexes if the changes are correct I would fixturize other test cases

[pep8speaks]

Hello @nixphix! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated on January 01, 2019 at 15:55 Hours UTC

[jreback]

prob you just want to do the move & rename of the fixtures in a PR w/o actually changing anything else. Then in a future PR you can modify things, otherwise the diff is going to be pretty big.

[nixphix]

@jreback could please review the changes

[jreback]

pls merge master as well

[jreback]

can you rebase and update

[codecov]

Codecov Report

Merging #23943 into master will decrease coverage by 49.24%.
The diff coverage is 50%.

@@             Coverage Diff             @@
##           master   #23943       +/-   ##
===========================================
- Coverage   92.31%   43.07%   -49.25%     
===========================================
  Files         166      166               
  Lines       52335    52339        +4     
===========================================
- Hits        48313    22543    -25770     
- Misses       4022    29796    +25774

Flag	Coverage Δ
#multiple	?
#single	43.07% <50%> (+0.01%)	⬆️

Impacted Files	Coverage Δ
pandas/util/testing.py	50.4% <50%> (-37.36%)	⬇️
pandas/io/formats/latex.py	0% <0%> (-100%)	⬇️
pandas/core/categorical.py	0% <0%> (-100%)	⬇️
pandas/io/sas/sas_constants.py	0% <0%> (-100%)	⬇️
pandas/tseries/plotting.py	0% <0%> (-100%)	⬇️
pandas/tseries/converter.py	0% <0%> (-100%)	⬇️
pandas/io/formats/html.py	0% <0%> (-98.65%)	⬇️
pandas/core/groupby/categorical.py	0% <0%> (-95.46%)	⬇️
pandas/io/sas/sas7bdat.py	0% <0%> (-91.17%)	⬇️
pandas/io/sas/sas_xport.py	0% <0%> (-90.15%)	⬇️
... and 125 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aeff38d...0a1e7b7. Read the comment docs.

[codecov]

Codecov Report

Merging #23943 into master will increase coverage by 60.41%.
The diff coverage is 50%.

@@             Coverage Diff             @@
##           master   #23943       +/-   ##
===========================================
+ Coverage   31.88%    92.3%   +60.41%     
===========================================
  Files         166      166               
  Lines       52413    52416        +3     
===========================================
+ Hits        16714    48384    +31670     
+ Misses      35699     4032    -31667

Flag	Coverage Δ
#multiple	90.73% <50%> (+60.43%)	⬆️
#single	43.07% <50%> (+11.18%)	⬆️

Impacted Files	Coverage Δ
pandas/util/testing.py	87.62% <50%> (+50.03%)	⬆️
pandas/core/computation/check.py	90.9% <0%> (-1.4%)	⬇️
pandas/util/_test_decorators.py	90.54% <0%> (+4.05%)	⬆️
pandas/core/config_init.py	99.24% <0%> (+9.84%)	⬆️
pandas/compat/__init__.py	58.3% <0%> (+10.03%)	⬆️
pandas/core/reshape/util.py	100% <0%> (+11.53%)	⬆️
pandas/core/api.py	100% <0%> (+13.33%)	⬆️
pandas/compat/numpy/__init__.py	92.85% <0%> (+14.28%)	⬆️
pandas/io/formats/console.py	74.24% <0%> (+16.66%)	⬆️
pandas/core/dtypes/inference.py	98.38% <0%> (+18.38%)	⬆️
... and 127 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b6be69...bd4e246. Read the comment docs.

[nixphix]

@jreback all comments are resolved and checks passed

[jreback]

this looks pretty good. can you also add an ids for the fixtures so we have nice names as well (you might have to get creative to do this, e.g. parsing the function names0

[nixphix]

@jreback could you help me figure out what's causing build failure in py 3.7

The same test case passes in master while it's failing in the pull request.

Master

pandas/pandas/tests/test_base.py

Lines 270 to 278 in c1be6b1

	def test_none_comparison(self):
	# bug brought up by #1079
	# changed from TypeError in 0.17.0
	for o in self.is_valid_objs:
	if isinstance(o, Series):
	o[0] = np.nan

Pull Request

pandas/pandas/tests/test_base.py

Lines 266 to 271 in bd4e246

	def test_none_comparison(self, all_series_fixture):
	# bug brought up by #1079
	# changed from TypeError in 0.17.0
	s = all_series_fixture
	s[0] = np.nan

Much appreciate your help

[WillAyd]

@nixphix can you merge master and check failures?

[WillAyd]

Closing as stale. Ping if you'd like to continue