Skip to content

De-privatize tslibs functions #21714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 3, 2018
Merged

De-privatize tslibs functions #21714

merged 3 commits into from
Jul 3, 2018

Conversation

jbrockmendel
Copy link
Member

Related: an item on the tslibs TODO list, #21698.

@codecov
Copy link

codecov bot commented Jul 3, 2018

Codecov Report

Merging #21714 into master will decrease coverage by <.01%.
The diff coverage is 69.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #21714      +/-   ##
==========================================
- Coverage    91.9%    91.9%   -0.01%     
==========================================
  Files         158      158              
  Lines       49690    49688       -2     
==========================================
- Hits        45670    45668       -2     
  Misses       4020     4020
Flag Coverage Δ
#multiple 90.28% <69.23%> (-0.01%) ⬇️
#single 41.95% <0%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/indexes/accessors.py 90.09% <ø> (-0.1%) ⬇️
pandas/core/indexes/datetimelike.py 96.72% <100%> (ø) ⬆️
pandas/core/indexes/period.py 92.57% <62.5%> (-0.02%) ⬇️
pandas/tseries/frequencies.py 95.9% <75%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cd2679...fd393df. Read the comment docs.

@gfyoung gfyoung added the Clean label Jul 3, 2018
Copy link
Member

@gfyoung gfyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jreback jreback added this to the 0.24.0 milestone Jul 3, 2018
@jreback jreback merged commit 7b63769 into pandas-dev:master Jul 3, 2018
@jreback
Copy link
Contributor

jreback commented Jul 3, 2018

thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the priv2 branch July 11, 2018 20:24
Sup3rGeo pushed a commit to Sup3rGeo/pandas that referenced this pull request Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants