Skip to content

BLD: add tempita files to depends #13960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

chris-b1
Copy link
Contributor

This change makes it so that if a .pxi.in file is modified, the appropriate module will be rebuilt.

@jreback
Copy link
Contributor

jreback commented Aug 11, 2016

what's the repro on current master?

change an .in and everything recompiles?

@chris-b1
Copy link
Contributor Author

Opposite - e.g., change algos_take_helper.pxi.in and nothing recompiles, if it was already up to date.

@codecov-io
Copy link

codecov-io commented Aug 11, 2016

Current coverage is 85.29% (diff: 100%)

Merging #13960 into master will increase coverage by <.01%

@@             master     #13960   diff @@
==========================================
  Files           139        139          
  Lines         50164      50164          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          42788      42789     +1   
+ Misses         7376       7375     -1   
  Partials          0          0          

Powered by Codecov. Last update 257ac88...d3ccf13

@jorisvandenbossche jorisvandenbossche added the Build Library building on various platforms label Aug 11, 2016
@jorisvandenbossche
Copy link
Member

Looks good to me

@jreback jreback added this to the 0.19.0 milestone Aug 11, 2016
@jreback jreback closed this in a963139 Aug 11, 2016
@jreback
Copy link
Contributor

jreback commented Aug 11, 2016

thanks!

@chris-b1 chris-b1 deleted the pxi-dep branch August 18, 2016 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Library building on various platforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants