ENH: Faster merge_asof() performs a single pass when joining tables (#13902) #13903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lint failed with I will fix this in a subsequent update. |
jreback
added
Datetime
Current coverage is 85.29% (diff: 97.72%)@@ master #13903 diff @@
==========================================
Files 139 139
Lines 50143 50154 +11
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 42776 42780 +4
- Misses 7367 7374 +7
Partials 0 0
|
|
First attempt at Tempita. More work needed still -- not ready for merge yet. |
|
While Travis is running, here are the latest benchmarks: This can handle |
|
it's fine to limit this for now |
|
@jreback Alright, I've made it explicit now, both in the documentation and in the validation. |
| # choose appropriate function by type | ||
| on_dtype = left_values.dtype | ||
| by_dtype = left_by_values.dtype | ||
| if is_integer_dtype(by_dtype): |
There was a problem hiding this comment.
need a more generic way of getting these
There was a problem hiding this comment.
see core/algorithms.py, basically put tuple of the args in a dict then get it
e.g.
_asof_funcs = { ('int64', 'double') : .....,
('int64', 'int64'): ....}
|
just merged #13925 pls rebase and can merge this |
…13902) Uses Tempita for different specializations of "by" and "on" types. These parameters can only take a single label now.
|
@jreback Everything has been rebased and pushed. Thanks! |
|
thanks @chrisaycock very nice! 2 things for future:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version passes existing regression tests but is ultimately wrong
because it requires the "by" column to be a single object. A proper version
would handle int (and possily float) columns through type differentiation.