-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
DOC: Fixes LaTeX build error #12586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Fixes LaTeX build error #12586
Conversation
@TomAugspurger at your leisure |
One API question, do we want to expose |
Actually, that seems to be an issue just with my build, as the traivs docs have it linked correctly: http://pandas-docs.github.io/pandas-docs-travis/api.html#resampling |
hmm, btw make sure that in your doc-build env you actually have an installed pandas of master/latest (you can simply install from conda), as it doesn't use the current one (as you are in |
side note, this is master: https://travis-ci.org/pydata/pandas/jobs/115054959 there is a seg fault right at the end of building the docs (before all of the I don't get this locally. |
@TomAugspurger ok I am pretty much done with doc changes. So pls build at your leisure (or you can wait for the final tag prob sunday eve) |
Ok, I'll merge this, and then build later tonight probably. You're last suggestion about having a real install fixed the link issues. Not sure about the segfault in travis. The error this is fixing does occur towards the end of the build, but is probably unrelated. I'll look into it tonight. |
gr8 yeah I noticed the segfault as was looking thru logs i bet it's for the latex building on Travis |
actually. let's let everything turn green. I'll push the 0.18.0 tag later today. You can build (and if anything else you need to fix, just include it and do a PR later). Then can release on sunday. |
just did a quick build. Seems like the API reference is having trouble with the accessors (.str, .dt, .plot). It's also not linking /building those properly in the dev build. http://pandas-docs.github.io/pandas-docs-travis/api.html#string-handling Other than that, things seem ok at a glance. Gotta run for now, but I'll investigate later. |
thanks @TomAugspurger lmk. |
@TomAugspurger about the API docs, yes, that is a known issue: #12161. I intended to look at it, but won't be able to do this for 0.18.0. I can do it later in April, but if you can have a look now, great! (but if you cannot directly fix it, it shouldn't hold up the release. Another possibility is building with 1.1.3, which I thought still worked but I am not sure). |
Oh, I assumed that section in the wiki with sphinx==1.1.3 was just out of date :) I’ll try both 1.1.3 and seeing what’s wrong.
|
Well, it should be :-) We should maybe actually also test sphinx 1.4, which is in beta. |
The instructions in the docs also need an update: http://pandas-docs.github.io/pandas-docs-travis/contributing.html#requirements (> 1.3.2 also works now: #10316) |
The PDF doc build was chocking on the
Parameters
section being the first item.