TST/DOC #10846 Test and document use of SQLAlchemy expressions in read_sql() #10983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
added
Testing
|
@stephenpascoe Sorry for the late reply. So this actually already just worked. Thanks a lot for the tests. And nice docs! Two questions:
|
stephenpascoe
force-pushed
the
issue-10846
branch
from
e24edad to
f26a191
Compare
Documentation describing how to use SQLALchemy Selectable and TextClause objects in read_sql(). Updated read_sql/read_sql_query docstrings.
stephenpascoe
force-pushed
the
issue-10846
branch
from
f26a191 to
c9476bd
Compare
|
Squashed, docstrings added and rebased. |
|
Thanks a lot! |
jorisvandenbossche
added a commit
that referenced
this pull request
Sep 22, 2015
TST/DOC #10846 Test and document use of SQLAlchemy expressions in read_sql()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides 2 tests using SQLALchemy expressions to read SQL data into a dataframe and accompanying documentation.
It attempts to address #10846 by explaining how this feature is already supported by pandas.
Closes #10846