Skip to content

TYP: type error in pandas/io/excel/_xlsxwriter.py #35994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fangchenli opened this issue Aug 30, 2020 · 0 comments · Fixed by #35995
Closed

TYP: type error in pandas/io/excel/_xlsxwriter.py #35994

fangchenli opened this issue Aug 30, 2020 · 0 comments · Fixed by #35995
Labels
Typing type annotations, mypy/pyright type checking
Milestone
1.2

Comments

@fangchenli
Copy link
Member

Those are some of the typing errors generated by mypy after unpining it.

pandas/io/excel/_xlsxwriter.py:105: error: "object" has no attribute "__iter__"; maybe "__str__" or "__dir__"? (not iterable)  [attr-defined]
pandas/io/excel/_xlsxwriter.py:196: error: "None" has no attribute "close"  [attr-defined]
pandas/io/excel/_xlsxwriter.py:207: error: "None" has no attribute "add_worksheet"  [attr-defined]
pandas/io/excel/_xlsxwriter.py:225: error: "None" has no attribute "add_format"  [attr-defined]
@fangchenli fangchenli added Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Aug 30, 2020
fangchenli added a commit to fangchenli/pandas that referenced this issue Aug 30, 2020
@fangchenli
TYP: typing errors in _xlsxwriter.py pandas-dev#35994
2b9d262
@fangchenli fangchenli mentioned this issue Aug 30, 2020
Merged
3 tasks
@simonjayhawkins simonjayhawkins added Typing type annotations, mypy/pyright type checking and removed Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Aug 30, 2020
mroeschke pushed a commit that referenced this issue Aug 31, 2020
@fangchenli
TYP: typing errors in _xlsxwriter.py #35994 (#35995)
b8981f4 
* TYP: typing errors in _xlsxwriter.py #35994

* TYP: add param type

* TYP: remove book=None in base class
@simonjayhawkins simonjayhawkins added this to the 1.2 milestone Aug 31, 2020
jbrockmendel pushed a commit to jbrockmendel/pandas that referenced this issue Aug 31, 2020
@fangchenli @jbrockmendel
TYP: typing errors in _xlsxwriter.py pandas-dev#35994 (pandas-dev#35995)
428d957 
* TYP: typing errors in _xlsxwriter.py pandas-dev#35994

* TYP: add param type

* TYP: remove book=None in base class
kesmit13 pushed a commit to kesmit13/pandas that referenced this issue Nov 2, 2020
@fangchenli
TYP: typing errors in _xlsxwriter.py pandas-dev#35994 (pandas-dev#35995)
a5c6e6e 
* TYP: typing errors in _xlsxwriter.py pandas-dev#35994

* TYP: add param type

* TYP: remove book=None in base class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
1.2
Development

Successfully merging a pull request may close this issue.

TYP: typing errors in _xlsxwriter.py #35994 fangchenli/pandas
2 participants
@fangchenli @simonjayhawkins