Add types for pandas.DataFrame.map #801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dr-Irv
requested changes
Oct 20, 2023
|
precommit is failing because you didn't format with See https://github.com/pandas-dev/pandas-stubs/blob/main/docs/setup.md to set up your environment. |
|
Also CI is failing because pyright 1.1.332 is picking up stuff we need to investigate. Can you put |
|
pyright seems to now enforce more checks for stub files
I will try to look into that. |
andrewpmk
force-pushed
the
main
branch
2 times, most recently
from
6374fed to
911dc2e
Compare
|
Made some changes:
|
- Removed stub and test for applymap - Downgraded pyright - Ran the precommit (it just removes some whitespace)
twoertwein
approved these changes
Oct 22, 2023
This was referenced Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added types for pandas.DataFrame.map (renamed from applymap in pandas 2.1.0 and later https://pandas.pydata.org/docs/dev/reference/api/pandas.DataFrame.map.html, applymap has been deprecated)
.mapmethod ofpd.DataFrameandmypy#774 and Missing stub for df.map() in pandas-stubs/core/frame.pyi #800