-
-
Notifications
You must be signed in to change notification settings - Fork 143
align typing with pandas source #1219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Great job in here, I think this is a major improvement. Hopefully that can unblock the other issue in pandas repo. |
For now, I'd rather mirror what is in the |
@twoertwein thanks for the review. I've pushed a new version that addresses your comments (and commented on a few other comments where I didn't make a change) |
Thanks @Dr-Irv ! |
Possibly closes #128
I went through the current pandas source in
pandas/_typing.py
and separated the types declared there from the "private" types only used in the stubs, which now appear at the bottom of the file, and added documentation where appropriate to indicate where things are different.Unclear whether the "private" types in the stubs should all be preceded by underscores. They are imported from
pandas/_typing
, so that makes them private anyway. When I wrote #128, I suggested to make them all private. Now that I have more experience with typing, I don't think it's necessary.By doing this, I have a list of types that should be "public" which will eventually go in
pandas.api.typing.aliases
. That will then allow me to work on pandas-dev/pandas#55231Asking for opinions of @loicdiridollou and a review/approval/merge from @twoertwein