fix: #1212 allow Series.name in pivot_table #1216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmp0xff
force-pushed
the
hotfix/cmp0xff/1212-series-name-in-pivot-table
branch
from
ca9c44e to
682aa19
Compare
|
It turns out that in |
Dr-Irv
requested changes
May 16, 2025
pandas-stubs/core/reshape/pivot.pyi
Outdated
Comment on lines
54
to
58
| PivotTableIndexTypes: TypeAlias = Label | Sequence[HashableT1] | Series | Grouper | None | ||
| PivotTableColumnsTypes: TypeAlias = ( | ||
| Label | Sequence[HashableT2] | Series | Grouper | None | ||
| ) | ||
| PivotTableValuesTypes: TypeAlias = Label | Sequence[HashableT3] | None |
There was a problem hiding this comment.
Can you make these private by preceding the names with an underscore?
There was a problem hiding this comment.
within stub files, that is OK
Dr-Irv
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assert_type()to assert the type of any return value