Skip to content

Introduce formatting bot #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 6, 2020
Merged

Introduce formatting bot #35

merged 5 commits into from
Jul 6, 2020

Conversation

steveklabnik
Copy link
Contributor

This bot will send a PR to any branch that missed rustfmt. Including
this one!

@steveklabnik steveklabnik mentioned this pull request Jul 2, 2020
Merged
6 tasks
@steveklabnik steveklabnik requested a review from cbiffle July 2, 2020 16:24
cbiffle
cbiffle approved these changes Jul 2, 2020
View reviewed changes
Copy link
Collaborator

@cbiffle cbiffle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go ahead and merge this (you may need to drop and regenerate the fix commit, as some things have changed).

@steveklabnik
Introduce formatting bot
6639467 
This bot will send a PR to any branch that missed rustfmt. Including
this one!
@steveklabnik
Ὀσυμανδύας
8827175 
'My name is Ozymandias, king of kings:
Look on my works, ye Mighty, and despair!'
Nothing beside remains. Round the decay
Of that colossal wreck, boundless and bare
The lone and level sands stretch far away.
@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2020

'My name is Ozymandias, king of kings:
Look on my works, ye Mighty, and despair!'
Nothing beside remains. Round the decay
Of that colossal wreck, boundless and bare
The lone and level sands stretch far away.

@oxidecomputer oxidecomputer deleted a comment from github-actions bot Jul 2, 2020
@steveklabnik
we don't need to hear from a bot every time.
504aa41
@steveklabnik
Let's explicitly skip the push step
e848911 
If there's nothing to push, this won't do anything, so it's fine the way
it was, but it's also really nice to see that it's skipped in the UI,
so let's do this explicitly.
@steveklabnik
Copy link
Contributor Author

I.... think my connection to matrix died? I'm not sure. Anyway, I'm gonna head out for the weekend, I will hold off on merging this until we can get the formatting diff to a spot where @bcantrill is happy :)

@cbiffle
Copy link
Collaborator

cbiffle commented Jul 2, 2020

Yeah, I've also lost Matrix. It's probably our server. Have a good weekend!

@bcantrill
Copy link
Collaborator

Thanks for doing this @steveklabnik! We should merge this -- my attempts to get rustfmt to be configured on the one issue that I have were fruitless. I did, however file an issue on rustfmt that captures what I would like to see; should that ever get addressed, it would be worth exploring enabling it. In the meantime, I, for one, welcome my new rustfmt overlords!

@steveklabnik
Copy link
Contributor Author

Okay! Gonna do the merge, then. Thanks folks!

@steveklabnik steveklabnik merged commit cc87a8a into master Jul 6, 2020
@steveklabnik steveklabnik deleted the format-task branch July 6, 2020 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbiffle cbiffle cbiffle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@steveklabnik @cbiffle @bcantrill