Skip to content

Use 'equal_range' instead of full scan for rule exceptions #2370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Use 'equal_range' instead of full scan for rule exceptions #2370

wants to merge 1 commit into from

Conversation

WGH-
Copy link
Contributor

@WGH- WGH- commented Jul 24, 2020

No description provided.

@zimmerle zimmerle self-requested a review July 28, 2020 13:37
@zimmerle zimmerle self-assigned this Jul 28, 2020
@zimmerle zimmerle added the 3.x Related to ModSecurity version 3.x label Jul 28, 2020
zimmerle added a commit that referenced this pull request Aug 10, 2020
@zimmerle
Use 'equal_range' instead of full scan for rule exceptions
b321829 
The original author was @WGH-, this change was proposed at #2370
@zimmerle
Copy link
Contributor

As of 3.1-experimental the majority of the UpdateActionBy? are pre-computed. Some parts of the change in this PR no longer exist in 3.1-experimental. I have made some modifications taking the approach suggested in the patch. Published here: b321829

zimmerle added a commit that referenced this pull request Aug 17, 2020
@zimmerle
Use 'equal_range' instead of full scan for rule exceptions
5a243f3 
The original author was @WGH-, this change was proposed at #2370
zimmerle added a commit that referenced this pull request Sep 18, 2020
@zimmerle
Use 'equal_range' instead of full scan for rule exceptions
cd2f9b8 
The original author was @WGH-, this change was proposed at #2370
zimmerle added a commit that referenced this pull request Sep 24, 2020
@zimmerle
Use 'equal_range' instead of full scan for rule exceptions
34d8199 
The original author was @WGH-, this change was proposed at #2370
zimmerle added a commit that referenced this pull request Oct 14, 2020
@zimmerle
Use 'equal_range' instead of full scan for rule exceptions
8ec7aef 
The original author was @WGH-, this change was proposed at #2370
@zimmerle
Copy link
Contributor

Merged! Thanks!

@zimmerle zimmerle closed this Oct 21, 2020
zimmerle added a commit that referenced this pull request Oct 21, 2020
@zimmerle
Use 'equal_range' instead of full scan for rule exceptions
89e1336 
The original author was @WGH-, this change was proposed at #2370
zimmerle added a commit that referenced this pull request Oct 21, 2020
@zimmerle
Use 'equal_range' instead of full scan for rule exceptions
0798aec 
The original author was @WGH-, this change was proposed at #2370
zimmerle added a commit that referenced this pull request Oct 23, 2020
@zimmerle
Use 'equal_range' instead of full scan for rule exceptions
30e9287 
The original author was @WGH-, this change was proposed at #2370
zimmerle added a commit that referenced this pull request Oct 29, 2020
@zimmerle
Use 'equal_range' instead of full scan for rule exceptions
71afd1a 
The original author was @WGH-, this change was proposed at #2370
zimmerle added a commit that referenced this pull request Nov 4, 2020
@zimmerle
Use 'equal_range' instead of full scan for rule exceptions
16e9802 
The original author was @WGH-, this change was proposed at #2370
zimmerle added a commit that referenced this pull request Nov 6, 2020
@zimmerle
Use 'equal_range' instead of full scan for rule exceptions
596b472 
The original author was @WGH-, this change was proposed at #2370
zimmerle added a commit that referenced this pull request Nov 9, 2020
@zimmerle
Use 'equal_range' instead of full scan for rule exceptions
75cb384 
The original author was @WGH-, this change was proposed at #2370
zimmerle added a commit that referenced this pull request Nov 16, 2020
@zimmerle
Use 'equal_range' instead of full scan for rule exceptions
281a4ca 
The original author was @WGH-, this change was proposed at #2370
zimmerle added a commit that referenced this pull request Nov 30, 2020
@zimmerle
Use 'equal_range' instead of full scan for rule exceptions
1bbbd92 
The original author was @WGH-, this change was proposed at #2370
zimmerle added a commit that referenced this pull request Dec 10, 2020
@zimmerle
Use 'equal_range' instead of full scan for rule exceptions
8226875 
The original author was @WGH-, this change was proposed at #2370
zimmerle added a commit that referenced this pull request Dec 23, 2020
@zimmerle
Use 'equal_range' instead of full scan for rule exceptions
0f1d3bf 
The original author was @WGH-, this change was proposed at #2370
zimmerle added a commit that referenced this pull request Jan 13, 2021
@zimmerle
Use 'equal_range' instead of full scan for rule exceptions
5c1095e 
The original author was @WGH-, this change was proposed at #2370
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimmerle zimmerle Awaiting requested review from zimmerle

Assignees

@zimmerle zimmerle

Labels
3.x Related to ModSecurity version 3.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WGH- @zimmerle