This repository was archived by the owner on May 28, 2021. It is now read-only.
Fix tutorial bugs #126
Closed
Fix tutorial bugs #126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an inconsistency where you add the mysql-agent sa to "my-namespace" but then proceed to add a database to "default". Set apiVersion to the correct value of "mysql.oracle.com/v1alpha1" --- I make this contribution available under the Apache License 2.0. I do not, and will not, sign the Oracle CLA as I do not feel it is worth the time nor money to have my attorney review it. Based on Oracle's past behavior with regard to the Linux community, I do not trust an Oracle agreement to have the best interest of the community as its intent thus will not sign without legal review.
|
@joejulian thank you for this. Much appreciated. I completely understand your hesitancy around the CLA and it's not a problem. We will open a separate PR and ensure we incorporate your changes. Thanks again. 👍 |
|
With the merge of #123 I believe this is now resolved. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an inconsistency where you add the mysql-agent sa to
"my-namespace" but then proceed to add a database to "default".
Set apiVersion to the correct value of "mysql.oracle.com/v1alpha1"
I make this contribution available under the Apache License 2.0. I do
not, and will not, sign nor agree to the Oracle CLA. I do not feel doing
so is worth the time nor money to have my attorney review it. Based
on Oracle's past behavior with regard to the Linux community, I do not
trust an Oracle agreement to have the best interest of the community
as its intent thus will not sign without legal review.