Skip to content

fix: prevent logs pollution for recursive matching algorithm #2060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 18, 2023
Merged

fix: prevent logs pollution for recursive matching algorithm #2060

merged 1 commit into from
Sep 18, 2023

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented Sep 18, 2023

No description provided.

@csviri csviri requested a review from metacosm September 18, 2023 11:41
@openshift-ci openshift-ci bot requested a review from adam-sandor September 18, 2023 11:41
@csviri csviri self-assigned this Sep 18, 2023
metacosm
metacosm reviewed Sep 18, 2023
View reviewed changes
Copy link
Collaborator

@metacosm metacosm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what this change is supposed to fix. How is changing the logging level addressing any recursion?

@csviri
Copy link
Collaborator Author

csviri commented Sep 18, 2023

I'm not sure what this change is supposed to fix. How is changing the logging level addressing any recursion?

So it is not polluting the logs on Debug level.

@metacosm
Copy link
Collaborator

OK, so I think this needs a better wording on the commit message then :)

@csviri csviri changed the title fix: logging recursive matching on trace level fix: logging improvements for matcher Sep 18, 2023
@csviri csviri changed the title fix: logging improvements for matcher fix: prevent logs pollution for recursive matching algorithm Sep 18, 2023
@csviri
Copy link
Collaborator Author

csviri commented Sep 18, 2023

OK, so I think this needs a better wording on the commit message then :)

Tried my best, changed the title. But feel free to change it :)

@metacosm metacosm merged commit a606fe9 into next Sep 18, 2023
@metacosm metacosm deleted the move-to-trace branch September 18, 2023 15:00
csviri added a commit that referenced this pull request Oct 3, 2023
@csviri
fix: logging recursive matching on trace level (#2060)
c71ca30 
Signed-off-by: Attila Mészáros <[email protected]>
shawkins pushed a commit to shawkins/java-operator-sdk that referenced this pull request Oct 4, 2023
@csviri @shawkins
fix: logging recursive matching on trace level (operator-framework#2060)
45ed42c 
Signed-off-by: Attila Mészáros <[email protected]>
csviri added a commit that referenced this pull request Oct 4, 2023
@csviri
fix: logging recursive matching on trace level (#2060)
75fd6d3 
Signed-off-by: Attila Mészáros <[email protected]>
csviri added a commit that referenced this pull request Oct 18, 2023
@csviri
fix: logging recursive matching on trace level (#2060)
28f841a 
Signed-off-by: Attila Mészáros <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metacosm metacosm metacosm approved these changes

@adam-sandor adam-sandor Awaiting requested review from adam-sandor

Assignees

@csviri csviri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@csviri @metacosm