Skip to content

improvement: bulk dependent resource api #1525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 7, 2022
Merged

improvement: bulk dependent resource api #1525

merged 9 commits into from
Oct 7, 2022

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented Oct 6, 2022

For bulk DR the desired is always computed anyways, this is a better / cleaner API.

@csviri csviri self-assigned this Oct 6, 2022
@csviri csviri requested a review from metacosm October 6, 2022 08:19
@csviri csviri force-pushed the next branch 2 times, most recently from 11feef9 to 0092f0a Compare October 6, 2022 09:04
csviri added 2 commits October 7, 2022 13:22
# Conflicts:
#	operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/AnnotationControllerConfiguration.java
#	operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/AbstractDependentResource.java
#	operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/BulkDependentResource.java
#	operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/kubernetes/KubernetesDependentResource.java
#	operator-framework/src/test/java/io/javaoperatorsdk/operator/sample/bulkdependent/ConfigMapDeleterBulkDependentResource.java
#	operator-framework/src/test/java/io/javaoperatorsdk/operator/sample/bulkdependent/external/ExternalBulkDependentResource.java
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 23 Code Smells

25.8% 25.8% Coverage
0.0% 0.0% Duplication

@metacosm metacosm merged commit 7442012 into next Oct 7, 2022
@metacosm metacosm deleted the bulk-get-resources branch October 7, 2022 12:08
csviri added a commit that referenced this pull request Oct 19, 2022
* feat: decouple event source from cache + list discriminator (#1378)

* feat: bulk dependent resources (#1448)

* feat: optional eventsource on dependent resources (#1479)

* refactor: simplify handling of reused event sources (#1518)



Co-authored-by: Chris Laprun <[email protected]>

* refactor: isolate index handling to BulkDependentResource interface (#1517)

* feat: key based bulk resource creation (#1521)

* improvement: bulk dependent resource api

* merge

Co-authored-by: Chris Laprun <[email protected]>
Co-authored-by: Chris Laprun <[email protected]>
csviri added a commit that referenced this pull request Oct 21, 2022
* feat: decouple event source from cache + list discriminator (#1378)

* feat: bulk dependent resources (#1448)

* feat: optional eventsource on dependent resources (#1479)

* refactor: simplify handling of reused event sources (#1518)



Co-authored-by: Chris Laprun <[email protected]>

* refactor: isolate index handling to BulkDependentResource interface (#1517)

* feat: key based bulk resource creation (#1521)

* improvement: bulk dependent resource api

* merge

Co-authored-by: Chris Laprun <[email protected]>
Co-authored-by: Chris Laprun <[email protected]>
csviri added a commit that referenced this pull request Oct 25, 2022
* feat: decouple event source from cache + list discriminator (#1378)

* feat: bulk dependent resources (#1448)

* feat: optional eventsource on dependent resources (#1479)

* refactor: simplify handling of reused event sources (#1518)



Co-authored-by: Chris Laprun <[email protected]>

* refactor: isolate index handling to BulkDependentResource interface (#1517)

* feat: key based bulk resource creation (#1521)

* improvement: bulk dependent resource api

* merge

Co-authored-by: Chris Laprun <[email protected]>
Co-authored-by: Chris Laprun <[email protected]>
csviri added a commit that referenced this pull request Oct 28, 2022
* feat: decouple event source from cache + list discriminator (#1378)

* feat: bulk dependent resources (#1448)

* feat: optional eventsource on dependent resources (#1479)

* refactor: simplify handling of reused event sources (#1518)



Co-authored-by: Chris Laprun <[email protected]>

* refactor: isolate index handling to BulkDependentResource interface (#1517)

* feat: key based bulk resource creation (#1521)

* improvement: bulk dependent resource api

* merge

Co-authored-by: Chris Laprun <[email protected]>
Co-authored-by: Chris Laprun <[email protected]>
csviri added a commit that referenced this pull request Oct 31, 2022
* feat: decouple event source from cache + list discriminator (#1378)

* feat: bulk dependent resources (#1448)

* feat: optional eventsource on dependent resources (#1479)

* refactor: simplify handling of reused event sources (#1518)



Co-authored-by: Chris Laprun <[email protected]>

* refactor: isolate index handling to BulkDependentResource interface (#1517)

* feat: key based bulk resource creation (#1521)

* improvement: bulk dependent resource api

* merge

Co-authored-by: Chris Laprun <[email protected]>
Co-authored-by: Chris Laprun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants