Skip to content

refactor: remove smoke-test-samples #1384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 24, 2022
Merged

refactor: remove smoke-test-samples #1384

merged 1 commit into from
Aug 24, 2022

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented Aug 3, 2022

IMO these are pretty obsolete (at least I did not open them for a very long time)

@csviri csviri self-assigned this Aug 3, 2022
@csviri csviri force-pushed the remove-smoke-test-samples branch from 4b0e190 to b3adc13 Compare August 5, 2022 11:13
@metacosm
Copy link
Collaborator

metacosm commented Aug 8, 2022

Sure but aren't they used to check backwards compatibility?

@csviri
Copy link
Collaborator Author

csviri commented Aug 22, 2022

Sure but aren't they used to check backwards compatibility?

Probably not, at least that is also covered by the normal samples.
Basically the default samples cover that.

@metacosm metacosm force-pushed the remove-smoke-test-samples branch from b3adc13 to 41473f0 Compare August 23, 2022 20:08
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

43.3% 43.3% Coverage
0.0% 0.0% Duplication

@csviri csviri merged commit ccbaa3a into next Aug 24, 2022
@csviri csviri deleted the remove-smoke-test-samples branch August 24, 2022 07:01
csviri added a commit that referenced this pull request Aug 24, 2022
csviri added a commit that referenced this pull request Aug 25, 2022
csviri added a commit that referenced this pull request Aug 30, 2022
csviri added a commit that referenced this pull request Sep 5, 2022
karstengresch added a commit to karstengresch/java-operator-sdk that referenced this pull request Dec 1, 2022
csviri pushed a commit that referenced this pull request Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants