feat: use fabric8 client json mapper by default #1382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csviri
force-pushed
the
default-object-mapper-from-fabric8
branch
from
0d8a6d0 to
c63489c
Compare
metacosm
reviewed
Aug 8, 2022
| @@ -126,7 +127,7 @@ default boolean closeClientOnStop() { | |||
| } | |||
|
|
|||
| default ObjectMapper getObjectMapper() { | |||
| return OBJECT_MAPPER; | |||
There was a problem hiding this comment.
Shouldn't the constant be removed altogether, as well, then?
|
Kudos, SonarCloud Quality Gate passed! |
metacosm
approved these changes
Aug 17, 2022
metacosm
added a commit
that referenced
this pull request
Aug 18, 2022
Also remove constants to avoid mismatched configurations Co-authored-by: Chris Laprun <[email protected]>
csviri
added a commit
that referenced
this pull request
Aug 23, 2022
Also remove constants to avoid mismatched configurations Co-authored-by: Chris Laprun <[email protected]>
csviri
added a commit
that referenced
this pull request
Aug 24, 2022
Also remove constants to avoid mismatched configurations Co-authored-by: Chris Laprun <[email protected]>
metacosm
added a commit
that referenced
this pull request
Aug 25, 2022
…1403) * feat: use fabric8 client json mapper by default (#1382) Also remove constants to avoid mismatched configurations * refactor: make it easier to initialize mapper & cloner in subclasses Co-authored-by: Attila Mészáros <[email protected]>
csviri
added a commit
that referenced
this pull request
Aug 25, 2022
Also remove constants to avoid mismatched configurations Co-authored-by: Chris Laprun <[email protected]>
csviri
added a commit
that referenced
this pull request
Aug 30, 2022
Also remove constants to avoid mismatched configurations Co-authored-by: Chris Laprun <[email protected]>
csviri
added a commit
that referenced
this pull request
Sep 5, 2022
Also remove constants to avoid mismatched configurations Co-authored-by: Chris Laprun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The json mapper might be fine tuned for application in some cases, probably in the default case we should use that everywhere if possible.
see also: fabric8io/kubernetes-client#1308