Enable zero-elimination if dedup is activated #17291
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Optimize dedup's handling of blocks of all-zeros.
Description
Creating high-refcount dedup entries for checksums of each record size is inefficient when the record could be recorded as a hole instead.
Normally, zero-elimination is disabled if compression is not enabled, but in the dedup case, it is expected that the write will be skipped anyway, we are just optimizing the way the write is skipped.
How Has This Been Tested?
Types of changes
Checklist:
Signed-off-by
.