-
Notifications
You must be signed in to change notification settings - Fork 38
feat: get rid of bundle analyzer on by default in prod #646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Every run of `npm run build` generates a report.html file that includes file size stats. It's useless in most cases. We suggest to remove it (along with the dependency) in all MFEs. This shaves 14s (out of 174s) of the build on my laptop for the learning MFE build.
Thanks for the pull request, @regisb! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
This is ready for review. |
I personally refer to the generated That said, I could see the generation of the report perhaps being more an opt-in option when creating a build, e.g. |
The generation of report.html in production builds has the unfortunate side effect that it's also available on edx.org... See for instance: https://authn.edx.org/report.html |
+1 for keeping this functionality available (including for prod builds, which can be different than dev builds), as it's very useful - but I agree it shouldn't be on by default. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #646 +/- ##
=============================
=============================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Every run of
npm run build
generates a report.html file that includes file size stats. It's useless in most cases. We suggest to remove it (along with the dependency) in all MFEs.This shaves 14s (out of 174s) of the build on my laptop for the learning MFE build.