-
Notifications
You must be signed in to change notification settings - Fork 19
feat: support design tokens and paragon 23 #497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support design tokens and paragon 23 #497
Conversation
Thanks for the pull request, @dcoa! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
caeeceb
to
0f5d3a2
Compare
0f5d3a2
to
ffa5816
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master-design-tokens #497 +/- ##
=====================================================
Coverage 85.87% 85.87%
=====================================================
Files 27 27
Lines 439 439
Branches 102 104 +2
=====================================================
Hits 377 377
Misses 61 61
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ffa5816
to
9e74feb
Compare
0bd6803
to
6d1656c
Compare
6d1656c
to
6afddea
Compare
6afddea
to
d20040c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this is looking great!
It seems to be doing the same thing as openedx/frontend-app-authn#1436 (comment) by moving away from @extend
ing bootstrap utility classes. I'd like to make sure everyone is aligned on how to address that (it's very possible the conclusion will be "copying the utilities into the MFEs is best practice") before landing this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once this is rebased this one is good to merge!
d20040c
to
265f232
Compare
@brian-smith-tcril rebased :) |
8d35db0
into
openedx:master-design-tokens
Warning
This PR should not be merge to
master
directly, it should point tomaster-design-tokens
once the branch has been created.Description
This PR updates frontend app learner record to support CSS variables and the corresponding paragon design tokens.
Changes implemented
Important
This PR requires a compatible version with paragon 23 of dependencies because of that the following PRs need to be merged first: