Skip to content

feat: support design tokens and paragon 23 #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dcoa
Copy link
Contributor

@dcoa dcoa commented Mar 6, 2025

Warning

This PR should not be merge to master directly, it should point to master-design-tokens once the branch has been created.

Description

This PR updates frontend app learner record to support CSS variables and the corresponding paragon design tokens.

Changes implemented

  • Replace Paragon SCSS variables with CSS variables.
  • Update frontend build

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 6, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Mar 6, 2025

Thanks for the pull request, @dcoa!

This repository is currently maintained by @2U-aperture.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Mar 6, 2025
@dcoa dcoa marked this pull request as draft March 6, 2025 02:24
@dcoa dcoa changed the title Dcoa/design tokens support [WIP] feat: support design tokens and paragon 23 Mar 6, 2025
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Mar 6, 2025
@dcoa dcoa force-pushed the dcoa/design-tokens-support branch from caeeceb to 0f5d3a2 Compare March 7, 2025 22:54
@dcoa dcoa force-pushed the dcoa/design-tokens-support branch from 0f5d3a2 to ffa5816 Compare March 26, 2025 02:39
@dcoa dcoa added the create-sandbox open-craft-grove should create a sandbox environment from this PR label Mar 26, 2025
Copy link

codecov bot commented Mar 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.87%. Comparing base (85830d3) to head (265f232).
Report is 1 commits behind head on master-design-tokens.

Additional details and impacted files
@@                  Coverage Diff                  @@
##           master-design-tokens     #497   +/-   ##
=====================================================
  Coverage                 85.87%   85.87%           
=====================================================
  Files                        27       27           
  Lines                       439      439           
  Branches                    102      104    +2     
=====================================================
  Hits                        377      377           
  Misses                       61       61           
  Partials                      1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dcoa dcoa marked this pull request as ready for review March 26, 2025 02:42
@dcoa dcoa requested a review from brian-smith-tcril March 26, 2025 02:42
@dcoa dcoa force-pushed the dcoa/design-tokens-support branch from ffa5816 to 9e74feb Compare March 31, 2025 22:45
@dcoa dcoa changed the title [WIP] feat: support design tokens and paragon 23 feat: support design tokens and paragon 23 Mar 31, 2025
@dcoa dcoa force-pushed the dcoa/design-tokens-support branch from 0bd6803 to 6d1656c Compare April 1, 2025 04:41
@MaxFrank13 MaxFrank13 added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Apr 3, 2025
@MaxFrank13 MaxFrank13 moved this to Blocked in Aperture-Maintained Apr 3, 2025
@dcoa dcoa force-pushed the dcoa/design-tokens-support branch from 6d1656c to 6afddea Compare April 14, 2025 01:55
@dcoa dcoa force-pushed the dcoa/design-tokens-support branch from 6afddea to d20040c Compare April 22, 2025 04:47
Copy link
Contributor

@brian-smith-tcril brian-smith-tcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this is looking great!

It seems to be doing the same thing as openedx/frontend-app-authn#1436 (comment) by moving away from @extending bootstrap utility classes. I'd like to make sure everyone is aligned on how to address that (it's very possible the conclusion will be "copying the utilities into the MFEs is best practice") before landing this.

Copy link
Contributor

@brian-smith-tcril brian-smith-tcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once this is rebased this one is good to merge!

@dcoa dcoa force-pushed the dcoa/design-tokens-support branch from d20040c to 265f232 Compare May 9, 2025 01:00
@dcoa
Copy link
Contributor Author

dcoa commented May 9, 2025

@brian-smith-tcril rebased :)

@brian-smith-tcril brian-smith-tcril changed the base branch from master to master-design-tokens May 9, 2025 14:18
@brian-smith-tcril brian-smith-tcril merged commit 8d35db0 into openedx:master-design-tokens May 9, 2025
6 checks passed
@openedx-webhooks openedx-webhooks removed the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label May 9, 2025
@github-project-automation github-project-automation bot moved this from Waiting on Author to Done in Contributions May 9, 2025
@github-project-automation github-project-automation bot moved this from Blocked to Done in Aperture-Maintained May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
create-sandbox open-craft-grove should create a sandbox environment from this PR open-source-contribution PR author is not from Axim or 2U
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants