Add Github Action CI tests #889
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuchfarber
force-pushed
the
tuchfarber/add_gha_ci_tests
branch
3 times, most recently
from
d5f3992 to
ea4959e
Compare
tuchfarber
force-pushed
the
tuchfarber/add_gha_ci_tests
branch
from
ea4959e to
8e1bb56
Compare
tuchfarber
commented
Nov 17, 2020
Comment on lines
9
to
10
| - MYSQL_ROOT_PASSWORD=password | ||
| - MYSQL_USER=credentials001 | ||
| - MYSQL_PASSWORD=password | ||
| - MYSQL_DATABASE=credentials |
There was a problem hiding this comment.
This change brought to you by tightening the restrictions on databases starting with test_ in mysql 5.6.46. docker-library/mysql#476
tuchfarber
commented
Nov 17, 2020
| @@ -13,7 +13,7 @@ services: | |||
| - DB_NAME=credentials | |||
| - DB_PASSWORD=password | |||
| - DB_PORT=3306 | |||
| - DB_USER=credentials001 | |||
| - DB_USER=root | |||
tuchfarber
commented
Nov 17, 2020
| @@ -64,7 +64,7 @@ class Meta: | |||
| uuid = factory.LazyFunction(uuid4) | |||
| title = FuzzyText(prefix="Test Program ") | |||
| type = FuzzyText() | |||
| type_slug = slugify(str(type)) | |||
| type_slug = factory.LazyAttribute(lambda o: slugify(o.type)) | |||
There was a problem hiding this comment.
This wasn't actually working before but mysql 5.6.X was handling the bad data fine.
tuchfarber
commented
Nov 17, 2020
Comment on lines
-127
to
+130
| docker exec -e TOXENV=$(TOXENV) -it credentials bash -c 'source /edx/app/credentials/credentials_env && cd /edx/app/credentials/credentials/ && xvfb-run make tests' | ||
| docker exec -e TOXENV=$(TOXENV) -t credentials bash -c 'source /edx/app/credentials/credentials_env && cd /edx/app/credentials/credentials/ && xvfb-run make tests' | ||
|
|
||
| exec-accept: ## Run acceptance tests on a container | ||
| docker exec -it credentials bash -c 'source /edx/app/credentials/credentials_env && cd /edx/app/credentials/credentials/ && make accept' | ||
| docker exec -t credentials bash -c 'source /edx/app/credentials/credentials_env && cd /edx/app/credentials/credentials/ && make accept' |
There was a problem hiding this comment.
We're not actually uses interactive mode and GHA fails when Travis didn't
|
Merging w/ comments to unblock team in the morning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is v1 to unblock credentials. Cleanup will happen later.