Skip to content

RHOAIENG-24411: Create Juptyer Minimum Python 3.12 image #1045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: python-3.12
Choose a base branch
from

Conversation

dibryant
Copy link
Contributor

@dibryant dibryant commented May 8, 2025

Fixes for https://issues.redhat.com/browse/RHOAIENG-24411

Description

Created Jupyter Minimum Python 3.12 Image.

How Has This Been Tested?

$ make jupyter-minimal-ubi9-python-3.12
     -e RELEASE_PYTHON_VERSION=3.12
     -e IMAGE_REGISTRY="quay.io/${YOUR_USER}/workbench-images" \
     -e RELEASE="2025b" \
     -e CONTAINER_BUILD_CACHE_ARGS="" \
     -e PUSH_IMAGES="no"

ensuring the Notebook works properly:

$ export QUAY_IMAGE=$(podman images --format "{{.Repository}}:{{.Tag}}" | head -1)
$ podman run -it -p 8888:8888 $QUAY_IMAGE

after opening URL

import sys
print(sys.version)

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@jiridanek
Copy link
Member

jiridanek commented May 9, 2025

RHOAIENG-24411: Upgrade Juptyer Minimum to Python 3.12

Is this the correct PR title? The PR is creating entirely new 3.12 image, it is not upgrading anything.

@dibryant dibryant changed the title (WIP) RHOAIENG-24411: Upgrade Juptyer Minimum to Python 3.12 (WIP) RHOAIENG-24411: Create Juptyer Minimum Python 3.12 image May 9, 2025
@openshift-ci openshift-ci bot added size/xxl and removed size/xxl labels May 9, 2025
@dibryant
Copy link
Contributor Author

dibryant commented May 9, 2025

RHOAIENG-24411: Upgrade Juptyer Minimum to Python 3.12

Is this the correct PR title? The PR is creating entirely new 3.12 image, it is not upgrading anything.

Yes sorry changed the title would better word it next time

@jiridanek
Copy link
Member

make jupyter-minimal-ubi9-python-3.12 \
     -e RELEASE_PYTHON_VERSION=3.12

That's not a bad idea on its own, but sadly it does not work with Github actions in this repo. For now, let me just add -3.12 entry to Makefile.

@jiridanek
Copy link
Member

It's more about having one version under development/testing for a future release

and under continuous integration, that's the one thing this PR is missing.

@daniellutz
Copy link
Contributor

daniellutz commented May 12, 2025

@jiridanek and providing a way to build and test multiple Python versions would help on that, in a way that we can understand, test and ensure that the next upgrades/scenarios/requirements are in accordance (not yet talking about released versions on support / maintenance, only the ability to build and test images)

I know that context is important and things were done the way they should back then, the same way that it's important to have discussions about the next steps, so let's figure out how this can happen in the best way possible :)

@jiridanek
Copy link
Member

Well, let's wait for the renaming pr from Harshad, and then we can create a new imagestream for this 3.12 image and we'd be pretty much done for now

@jiridanek
Copy link
Member

Next, we ask Adriel if he wants 3.12 version of every image in the repo, or about half, or just a few.

If just a few, then I'd just add makefile entry and imagestream in ad hoc way.

If he wants all, then we should think how to make doing that easi(er) and adopt such repo structure.

@daniellutz
Copy link
Contributor

For now, as far as I remember, the main idea was to build and test to see if the workbenches would work with Python 3.12 on the minimal and data science images, not the others, at least for now.

@openshift-ci openshift-ci bot added size/xxl and removed size/xxl labels May 15, 2025
@dibryant dibryant changed the title (WIP) RHOAIENG-24411: Create Juptyer Minimum Python 3.12 image RHOAIENG-24411: Create Juptyer Minimum Python 3.12 image May 16, 2025
@dibryant dibryant changed the base branch from main to python-3.12 May 19, 2025 16:26
@openshift-ci openshift-ci bot added size/xxl and removed size/xxl labels May 19, 2025
Copy link
Contributor

openshift-ci bot commented May 20, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign caponetto for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@adrielparedes
Copy link
Member

@jiridanek @daniellutz @dibryant what is needed to merge this on the feature branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants