-
Notifications
You must be signed in to change notification settings - Fork 87
RHOAIENG-24411: Create Juptyer Minimum Python 3.12 image #1045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: python-3.12
Are you sure you want to change the base?
Conversation
Is this the correct PR title? The PR is creating entirely new 3.12 image, it is not upgrading anything. |
Yes sorry changed the title would better word it next time |
That's not a bad idea on its own, but sadly it does not work with Github actions in this repo. For now, let me just add -3.12 entry to Makefile. |
and under continuous integration, that's the one thing this PR is missing. |
@jiridanek and providing a way to build and test multiple Python versions would help on that, in a way that we can understand, test and ensure that the next upgrades/scenarios/requirements are in accordance (not yet talking about released versions on support / maintenance, only the ability to build and test images) I know that context is important and things were done the way they should back then, the same way that it's important to have discussions about the next steps, so let's figure out how this can happen in the best way possible :) |
Well, let's wait for the renaming pr from Harshad, and then we can create a new imagestream for this 3.12 image and we'd be pretty much done for now |
Next, we ask Adriel if he wants 3.12 version of every image in the repo, or about half, or just a few. If just a few, then I'd just add makefile entry and imagestream in ad hoc way. If he wants all, then we should think how to make doing that easi(er) and adopt such repo structure. |
For now, as far as I remember, the main idea was to build and test to see if the workbenches would work with Python 3.12 on the minimal and data science images, not the others, at least for now. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jiridanek @daniellutz @dibryant what is needed to merge this on the feature branch? |
Fixes for https://issues.redhat.com/browse/RHOAIENG-24411
Description
Created Jupyter Minimum Python 3.12 Image.
How Has This Been Tested?
ensuring the Notebook works properly:
after opening URL
Merge criteria: