Skip to content

Fix crash while building opencv for OSX #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 20, 2018
Merged

Fix crash while building opencv for OSX #110

merged 2 commits into from
Jul 20, 2018

Conversation

yonip
Copy link

@yonip yonip commented Jul 19, 2018

The original crash was caused by scikit-build both prioritizes command line options over the parameters passed to the setup function, and that it defaults the command line options for -DCMAKE_OSX_DEPLOYMENT_TARGET and for -DCMAKE_OSX_ARCHITECTURES without checking that setup was passed those parameters.
(this is where scikit-build defaults the command line parameters, and this is where the command line parameters are combined with the passed in parameters).
As a workaround, I overrode one function in multibuild's common_utils.sh in config.sh that allows for extra command line parameters to be passed to setup.py, and set the parameters only for OSX tests in .travis.yml.
Also fix a later crash where install_run crashed on OSX builds with Python 3.7, where the TEST_DEPENDS environment variable defaulted to numpy==1.11.1 where Python 3.7 requires numpy==1.14.5.

@skvark
Copy link
Member

skvark commented Jul 19, 2018

Nice! Thanks a lot. I suspected that there was something overriding those params. Let's see how the builds go as I have been poking master branch today.

@jcfr
Copy link

jcfr commented Jul 29, 2018

Thanks @yonip for reporting the issue on scikit-build issue tracker and also thanks for your help to address the issue.

The problem should be fixed in the upcoming release of scikit-build, then specifying either plat-name macosx-10.7-x86_64 or -DCMAKE_OSX_DEPLOYMENT_TARGET:STRING=10.7 should have the expected effect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants