Fix crash while building opencv for OSX #110
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original crash was caused by scikit-build both prioritizes command line options over the parameters passed to the
setup
function, and that it defaults the command line options for-DCMAKE_OSX_DEPLOYMENT_TARGET
and for-DCMAKE_OSX_ARCHITECTURES
without checking thatsetup
was passed those parameters.(this is where scikit-build defaults the command line parameters, and this is where the command line parameters are combined with the passed in parameters).
As a workaround, I overrode one function in multibuild's
common_utils.sh
inconfig.sh
that allows for extra command line parameters to be passed to setup.py, and set the parameters only for OSX tests in.travis.yml
.Also fix a later crash where
install_run
crashed on OSX builds with Python 3.7, where theTEST_DEPENDS
environment variable defaulted tonumpy==1.11.1
where Python 3.7 requiresnumpy==1.14.5
.