Skip to content

fix: Expose SpanExporterBuilder and MetricExporterBuilder #2966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 21, 2025

Conversation

elichai
Copy link
Contributor

@elichai elichai commented May 14, 2025

Fixes #2358

Changes

Exposes SpanExporterBuilder and MetricExporterBuilder
Currently these are hidden even though they are exposed: https://docs.rs/opentelemetry-otlp/latest/opentelemetry_otlp/struct.SpanExporter.html#method.builder

@elichai elichai requested a review from a team as a code owner May 14, 2025 13:15
Copy link

linux-foundation-easycla bot commented May 14, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: elichai / name: Elichai Turkel (664b19e)
  • ✅ login: cijothomas / name: Cijo Thomas (59c09b9)

@elichai elichai force-pushed the expose-builders branch from d3f294b to 23dd408 Compare May 14, 2025 13:18
@elichai elichai force-pushed the expose-builders branch from 23dd408 to 664b19e Compare May 14, 2025 13:19
@elichai elichai changed the title Expose SpanExporterBuilder and MetricExporterBuilder fix: Expose SpanExporterBuilder and MetricExporterBuilder May 14, 2025
Copy link

codecov bot commented May 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.4%. Comparing base (cc93ead) to head (59c09b9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2966   +/-   ##
=====================================
  Coverage   81.4%   81.4%           
=====================================
  Files        126     126           
  Lines      24571   24571           
=====================================
+ Hits       20001   20005    +4     
+ Misses      4570    4566    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cijothomas cijothomas merged commit 857a38b into open-telemetry:main May 21, 2025
27 checks passed
@elichai elichai deleted the expose-builders branch May 21, 2025 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants