-
Notifications
You must be signed in to change notification settings - Fork 522
chore: remove redundant test logging #2943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore: remove redundant test logging #2943
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2943 +/- ##
=======================================
- Coverage 81.3% 81.3% -0.1%
=======================================
Files 126 126
Lines 24289 24289
=======================================
- Hits 19763 19759 -4
- Misses 4526 4530 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Had a quick skim for other instances and didn't find anything. Is it this simple? |
@scottgerring I compared the CI logs for integration test for this PR vs existing. The logs are not shown, for the CI runs in this PR, but it does show up in other PRs. What's your thought on removing our custom print-to-stdout, and instead rely on |
We could certainly do it, although I am apprehensive about adding more stuff that uses tracing within OTel - see e.g. the issue with telemetry suppression you were working on. I know that won't be a problem here, but I don't see so much value in adding it in - the main thing is to get diagnostics out. Do you have an opinion on it @cijothomas ? |
Fixes #2841
Design discussion issue (if applicable) #
Changes
Please provide a brief description of the changes here.
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes