build: Add static component pointers for LTO #13193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bosilca
previously approved these changes
Apr 14, 2025
devreal
previously approved these changes
Apr 14, 2025
jsquyres
reviewed
Apr 15, 2025
jsquyres
previously approved these changes
Apr 15, 2025
bwbarrett
force-pushed
the
bugfix/lto-is-a-pain
branch
from
e338bf4 to
79b9f3d
Compare
Add a bit of indirection on the hook initialization code to add a minimal amount of type checking around the component type. This still assumes that a const mca_base_component_t * can be cast to a const ompi_hook_base_component_ti *, but at least if the thing that we're reading from is giving us something other than a const mca_base_component_t *, the compiler will get angry with us. Signed-off-by: Brian Barrett <[email protected]>
With GCC's link time optimization, the compiler ends up seeing two declarations of MCA component structures. One in the component itself, which has potentially a component-specific type, and one in static-components.h, which is just declared as a base MCA component struct. The compiler doesn't like this. This patch adds a level of indirection used by the static component lookup code. static-components.h now declares the existance of a mca_component_t * and the list is of pointers to pointers. The MCA base framework has to do an extra dereference, but this is only in the initialization path. We also then have to have the actual pointer exist, so add a macro MCA_BASE_COMPONENT_INIT that we need to add to every component definition to create the pointer (and perhaps do more initialization later). Signed-off-by: Brian Barrett <[email protected]>
bwbarrett
force-pushed
the
bugfix/lto-is-a-pain
branch
from
79b9f3d to
93a4464
Compare
bosilca
approved these changes
May 13, 2025
devreal
approved these changes
May 13, 2025
This was referenced May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With GCC's link time optimization, the compiler ends up seeing two declarations of MCA component structures. One in the component itself, which has potentially a component-specific type, and one in static-components.h, which is just declared as a base MCA component struct. The compiler doesn't like this.
This patch adds a level of indirection used by the static component lookup code. static-components.h now declares the existance of a mca_component_t * and the list is of pointers to pointers. The MCA base framework has to do an extra dereference, but this is only in the initialization path. We also then have to have the actual pointer exist, so add a macro MCA_BASE_COMPONENT_INIT that we need to add to every component definition to create the pointer (and perhaps do more initialization later).