Fix export serverless functions on Node 14 #3417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportBase: 53.04% // Head: 53.02% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3417 +/- ##
==========================================
- Coverage 53.04% 53.02% -0.02%
==========================================
Files 270 270
Lines 5756 5756
Branches 1333 1333
==========================================
- Hits 3053 3052 -1
- Misses 2703 2704 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
zwliew
added a commit
that referenced
this pull request
Aug 5, 2023
Vercel disables Node 14 support on 15 Aug 2023, and Node 16 support on 6 Feb 2024. Let's future-proof and not worry about this for a while by supporting Node 18. References for migration to @sparticuz/chromium: * alixaxel/chrome-aws-lambda#275 * https://github.com/Sparticuz/chrome-aws-lambda * https://github.com/Sparticuz/chromium#migration-from-chrome-aws-lambda References for upgrading puppeteer: * https://pptr.dev/chromium-support References for prior Node upgrades: * #3417 * #3414
zwliew
added a commit
that referenced
this pull request
Aug 5, 2023
Vercel disables Node 14 support on 15 Aug 2023, and Node 16 support on 6 Feb 2024. Let's future-proof and not worry about this for a while by supporting Node 18. References for migration to @sparticuz/chromium: * alixaxel/chrome-aws-lambda#275 * https://github.com/Sparticuz/chrome-aws-lambda * https://github.com/Sparticuz/chromium#migration-from-chrome-aws-lambda References for upgrading puppeteer: * https://pptr.dev/chromium-support References for prior Node upgrades: * #3417 * #3414
zwliew
added a commit
that referenced
this pull request
Aug 5, 2023
Vercel disables Node 14 support on 15 Aug 2023, and Node 16 support on 6 Feb 2024. Let's future-proof and not worry about this for a while by supporting Node 18. References for migration to @sparticuz/chromium: * alixaxel/chrome-aws-lambda#275 * https://github.com/Sparticuz/chrome-aws-lambda * https://github.com/Sparticuz/chromium#migration-from-chrome-aws-lambda References for upgrading puppeteer: * https://pptr.dev/chromium-support References for prior Node upgrades: * #3417 * #3414
zwliew
added a commit
that referenced
this pull request
Aug 5, 2023
Vercel disables Node 14 support on 15 Aug 2023, and Node 16 support on 6 Feb 2024. Let's future-proof and not worry about this for a while by supporting Node 18. References for migration to @sparticuz/chromium: * alixaxel/chrome-aws-lambda#275 * https://github.com/Sparticuz/chrome-aws-lambda * https://github.com/Sparticuz/chromium#migration-from-chrome-aws-lambda References for upgrading puppeteer: * https://pptr.dev/chromium-support References for prior Node upgrades: * #3417 * #3414
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3415
Context
Vercel deprecated Node 12. We then migrated to Node 16 in #3414 if not the site doesn't build on Vercel. In the process, there was a regression with the export service, because
chrome-aws-lambdaandpuppeteer, in their older versions, do not work with Node v14/v16.This PR bumps their versions slightly to v6.0.0, which allows it to work with Node 14.
Note that this isn't the latest
chrome-aws-lambdanor the latestpuppeteer, because the APIs for puppeteer have changed a lot since and it takes more effort for us to migrate it to the latest API.These changes have also not been tested with Node 16 yet. I just lowered the build target to Node 14 first so that we minimise any environment API changes while fixing this issue.
This PR has been tested to fix the issue, and the fix has now been manually promoted to production on Vercel.
To test, click on this link to download my timetable.