Skip to content

feat: Add install apk on riscv64 arch tests #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2025
Merged

feat: Add install apk on riscv64 arch tests #43

merged 1 commit into from
Mar 26, 2025

Conversation

hustcer
Copy link
Contributor

@hustcer hustcer commented Mar 26, 2025

feat: Add install apk on riscv64 arch tests

Copy link

Script Analysis

  • New GitHub Actions workflow for testing Nu APK package installation on RISC-V (Alpine Linux)
  • Uses QEMU emulation for RISC-V architecture testing
  • Tests against multiple Alpine Linux versions (latest and 3.20)
  • Adds untrusted package repository (Gemfury) due to unsigned packages
  • Verifies installation by checking installed shell and running basic Nu commands

Security Review

  • ❗ Potential security risk using --allow-untrusted flag with apk (line 196) - packages aren't verified
  • ⚠️ Adds external repository (alpine.fury.io) without signature verification
  • Note: This appears to be temporary testing configuration rather than production deployment

Optimization Suggestions

  • Consider adding package verification step if/when packages become signed
  • Could add cleanup step to remove the repository after testing
  • Might want to validate the installed Nu version against expected version

Overall Quality: 4
(Good for testing purposes, but would need additional security measures for production use)

@hustcer hustcer merged commit b64a726 into main Mar 26, 2025
1 check passed
@hustcer hustcer deleted the feature/riscv branch March 26, 2025 13:24
hustcer added a commit to hustcer/integrations that referenced this pull request Mar 30, 2025
feat: Add install apk on riscv64 arch tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant