dependency on sphinx.ext.autosummary

[anntzer]

It appears that numpydoc has a hard dependency on sphinx.ext.autosummary being active (it inserts some .. autosummary:: directives). This is fine, but perhaps numpydoc.setup should just call sphinx.ext.autosummary.setup in that case? (in the sense that I don't see much of a point in erroring out instead, which is the current behavior if sphinx.ext.autosummary is not listed in conf.py)

[jnothman]

Strictly this is only true if numpydoc_show_class_members is true (which it is by default) add numpydoc processes class docstrings, or if the class docstrings explicitly list methods.

But assuming there is minimal risk in automatically installing autosummary, I am +1 for this.

[anntzer]

I guess you can even delay loading sphinx.ext.autosummary until the point where you actually know you'll need it, but that seems a bit overengineering it.

[pv]

Is calling other extension's setup.py the right way to do extension dependencies in Sphinx?

[anntzer]

Actually the correct way seems to be to call app.setup_extension, which is documented at http://www.sphinx-doc.org/en/stable/extdev/appapi.html?highlight=setup_extension and used e.g. by autosummary to load autodoc (https://github.com/sphinx-doc/sphinx/blob/master/sphinx/ext/autosummary/__init__.py#L623).

[jnothman]

Would you like to submit a PR? Thanks

[anntzer]

Nah, you get to do it :-) (no hurry)