http2: add diagnostics channel 'http2.client.stream.finish' #58317
+81
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
http2
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58317 +/- ##
=======================================
Coverage 90.23% 90.24%
=======================================
Files 633 633
Lines 186847 186857 +10
Branches 36685 36681 -4
=======================================
+ Hits 168594 168621 +27
+ Misses 11041 11036 -5
+ Partials 7212 7200 -12
🚀 New features to boost your workflow:
|
santigimeno
approved these changes
May 14, 2025
RaisinTen
force-pushed
the
http2-add-diagnostics-channel-http2.client.stream.finish
branch
from
74e4bbf to
ae48c9b
Compare
marco-ippolito
approved these changes
May 14, 2025
RaisinTen
added
the
diagnostics_channel
lpinca
approved these changes
May 15, 2025
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
RaisinTen
added
the
author ready
RaisinTen
force-pushed
the
http2-add-diagnostics-channel-http2.client.stream.finish
branch
from
ae48c9b to
91a3b55
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: Darshan Sen <[email protected]> PR-URL: nodejs#58317 Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
RaisinTen
force-pushed
the
http2-add-diagnostics-channel-http2.client.stream.finish
branch
from
91a3b55 to
ccf227e
Compare
|
Landed in ccf227e |
RaisinTen
deleted the
http2-add-diagnostics-channel-http2.client.stream.finish
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.