Skip to content

http2: add diagnostics channel 'http2.client.stream.error' #58306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2025
Merged

http2: add diagnostics channel 'http2.client.stream.error' #58306

merged 1 commit into from
May 16, 2025

Conversation

RaisinTen
Copy link
Member

No description provided.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/http2
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run. labels May 13, 2025
@codecov Codecov
Copy link

codecov bot commented May 13, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.23%. Comparing base (b197355) to head (928f0f8).
Report is 15 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #58306   +/-   ##
=======================================
  Coverage   90.23%   90.23%           
=======================================
  Files         633      633           
  Lines      186818   186827    +9     
  Branches    36668    36672    +4     
=======================================
+ Hits       168578   168591   +13     
- Misses      11036    11045    +9     
+ Partials     7204     7191   -13
Files with missing lines Coverage Δ
lib/internal/http2/core.js 95.47% <100.00%> (+0.01%) ⬆️

... and 26 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@RaisinTen RaisinTen mentioned this pull request May 13, 2025
Open
bjohansebas
bjohansebas approved these changes May 13, 2025
View reviewed changes
Copy link
Member

@bjohansebas bjohansebas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RaisinTen RaisinTen force-pushed the http2-add-diagnostics-channel-http2.client.stream.error branch from b15a8bd to 928f0f8 Compare May 14, 2025 07:54
@RaisinTen RaisinTen added diagnostics_channel Issues and PRs related to diagnostics channel request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels May 15, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@RaisinTen RaisinTen requested a review from cola119 May 15, 2025 14:30
@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 16, 2025
@RaisinTen RaisinTen requested a review from santigimeno May 16, 2025 05:53
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66831/

@RaisinTen RaisinTen requested review from ShogunPanda and Qard May 16, 2025 11:16
@RaisinTen RaisinTen added the commit-queue Add this label to land a pull request using GitHub Actions. label May 16, 2025
debadree25
debadree25 approved these changes May 16, 2025
View reviewed changes
Copy link
Member

@debadree25 debadree25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 16, 2025
@nodejs-github-bot nodejs-github-bot merged commit 8053a5c into nodejs:main May 16, 2025
68 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 8053a5c

@RaisinTen RaisinTen deleted the http2-add-diagnostics-channel-http2.client.stream.error branch May 16, 2025 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnb bnb bnb approved these changes

@lpinca lpinca lpinca approved these changes

@debadree25 debadree25 debadree25 approved these changes

@bjohansebas bjohansebas bjohansebas approved these changes

@cola119 cola119 Awaiting requested review from cola119

@santigimeno santigimeno Awaiting requested review from santigimeno

@ShogunPanda ShogunPanda Awaiting requested review from ShogunPanda

@Qard Qard Awaiting requested review from Qard

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. diagnostics_channel Issues and PRs related to diagnostics channel http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@RaisinTen @nodejs-github-bot @bnb @lpinca @debadree25 @bjohansebas