Skip to content

src: update std::vector<v8::Local<T>> to use v8::LocalVector<T> #57733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 5, 2025
Merged

src: update std::vector<v8::Local<T>> to use v8::LocalVector<T> #57733

merged 1 commit into from
Apr 5, 2025

Conversation

Aditi-1400
Copy link
Contributor

A follow up of #57578 to replace all std::vectorv8::Local to use v8::LocalVector

This is the last of these updates, we don't have anymore uses std::vector<v8::Local> after this :)

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Apr 2, 2025
@codecov Codecov
Copy link

codecov bot commented Apr 2, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.23%. Comparing base (1123585) to head (24bb4c7).
Report is 408 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #57733   +/-   ##
=======================================
  Coverage   90.22%   90.23%           
=======================================
  Files         630      630           
  Lines      185055   185074   +19     
  Branches    36216    36223    +7     
=======================================
+ Hits       166975   166997   +22     
- Misses      11042    11043    +1     
+ Partials     7038     7034    -4
Files with missing lines Coverage Δ
src/node_messaging.cc 83.55% <100.00%> (+0.71%) ⬆️

... and 32 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@RaisinTen RaisinTen added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Apr 3, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 3, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66036/

@RaisinTen RaisinTen added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 5, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 5, 2025
@nodejs-github-bot nodejs-github-bot merged commit 7e43337 into nodejs:main Apr 5, 2025
72 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 7e43337

JonasBa pushed a commit to JonasBa/node that referenced this pull request Apr 11, 2025
@Aditi-1400 @JonasBa
src: update std::vector<v8::Local<T>> to use v8::LocalVector<T>
69ea1b1 
Refs: nodejs#57578
PR-URL: nodejs#57733
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
RafaelGSS pushed a commit that referenced this pull request May 1, 2025
@Aditi-1400 @RafaelGSS
src: update std::vector<v8::Local<T>> to use v8::LocalVector<T>
d211a59 
Refs: #57578
PR-URL: #57733
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request May 1, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
@Aditi-1400 @RafaelGSS
src: update std::vector<v8::Local<T>> to use v8::LocalVector<T>
ed72044 
Refs: #57578
PR-URL: #57733
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
aduh95 pushed a commit that referenced this pull request May 6, 2025
@Aditi-1400 @aduh95
src: update std::vector<v8::Local<T>> to use v8::LocalVector<T>
c408a7f 
Refs: #57578
PR-URL: #57733
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
@jazelly jazelly mentioned this pull request May 13, 2025
Closed
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
@Aditi-1400 @RafaelGSS
src: update std::vector<v8::Local<T>> to use v8::LocalVector<T>
3a6d3a3 
Refs: #57578
PR-URL: #57733
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
jazelly pushed a commit to jazelly/node that referenced this pull request May 17, 2025
@Aditi-1400 @jazelly
src: update std::vector<v8::Local<T>> to use v8::LocalVector<T>
7d7603e 
Refs: nodejs#57578
PR-URL: nodejs#57733
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
@aduh95 aduh95 added dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. backport-requested-v22.x PRs awaiting manual backport to the v22.x-staging branch. and removed dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. labels May 17, 2025
@aduh95
Copy link
Contributor

aduh95 commented May 17, 2025

This breaks the Windows build on v22.x-staging, it would require a manual backport if we want to land it on 22.x.

aduh95 pushed a commit that referenced this pull request May 17, 2025
@Aditi-1400 @aduh95
src: update std::vector<v8::Local<T>> to use v8::LocalVector<T>
c41facb 
Refs: #57578
PR-URL: #57733
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig approved these changes

@Flarna Flarna Flarna approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-requested-v22.x PRs awaiting manual backport to the v22.x-staging branch. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Aditi-1400 @nodejs-github-bot @aduh95 @anonrig @Flarna @RaisinTen