src: initialize privateSymbols for per_context #57479

jazelly · 2025-03-15T05:18:56Z

In some cases, per_context files need to access privateSymbols. This commit lets GetPerContextExports to be able to pass down IsolateData to InitializePrimordials, so it can compile per_context files with privateSymbols from IsolateData.

With this change we can access privateSymbols in per_context/domexception.js like

const { transfer_mode_private_symbol } = privateSymbols;

nodejs-github-bot · 2025-03-15T05:19:01Z

Review requested:

@nodejs/startup

codecov · 2025-03-15T06:49:32Z

Codecov Report

Attention: Patch coverage is 75.75758% with 8 lines in your changes missing coverage. Please review.

Project coverage is 90.23%. Comparing base (a6d3585) to head (40c0219).
Report is 380 commits behind head on main.

Files with missing lines	Patch %	Lines
src/api/environment.cc	73.91%	2 Missing and 4 partials ⚠️
src/node_messaging.cc	75.00%	0 Missing and 2 partials ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #57479   +/-   ##
=======================================
  Coverage   90.23%   90.23%           
=======================================
  Files         630      630           
  Lines      185129   185077   -52     
  Branches    36234    36222   -12     
=======================================
- Hits       167049   167008   -41     
- Misses      11037    11039    +2     
+ Partials     7043     7030   -13

Files with missing lines	Coverage Δ
src/node_builtins.cc	`79.41% <100.00%> (+0.29%)`	⬆️
src/node_internals.h	`81.03% <ø> (ø)`
src/node_realm.cc	`73.41% <100.00%> (ø)`
src/node_messaging.cc	`83.49% <75.00%> (+0.38%)`	⬆️
src/api/environment.cc	`75.18% <73.91%> (-0.63%)`	⬇️

... and 27 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

nodejs-github-bot · 2025-03-16T12:32:15Z

CI: https://ci.nodejs.org/job/node-test-pull-request/65779/

nodejs-github-bot · 2025-03-17T06:28:54Z

CI: https://ci.nodejs.org/job/node-test-pull-request/65796/

src/node.h

src/api/environment.cc

legendecas

LGTM % a small nit

src/api/environment.cc

nodejs-github-bot · 2025-04-06T07:47:39Z

Landed in 79eddc6

PR-URL: nodejs#57479 Reviewed-By: Chengzhong Wu <[email protected]>

PR-URL: #57479 Reviewed-By: Chengzhong Wu <[email protected]>

aduh95 · 2025-05-06T16:48:09Z

This doesn't build on v22.x-staging, could you open a backport PR or add the dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. label please?

jazelly · 2025-05-07T11:29:19Z

blocked by the backport of #57519, but I don't see this should not land on v22.x, so I'll wait.

aduh95 · 2025-05-07T11:47:15Z

If you'd like to open a backport PR that includes both PRs, that'd be awesome – otherwise it might never happen

PR-URL: nodejs#57479 Reviewed-By: Chengzhong Wu <[email protected]>

PR-URL: nodejs#57479 Backport-PR-URL: nodejs#58217 Reviewed-By: Chengzhong Wu <[email protected]>

PR-URL: nodejs#57479 Reviewed-By: Chengzhong Wu <[email protected]>

PR-URL: #57479 Reviewed-By: Chengzhong Wu <[email protected]>

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Mar 15, 2025

jazelly force-pushed the expose-isolate-data branch 2 times, most recently from 4044d5d to 4c9445f Compare March 15, 2025 05:27

jazelly changed the title ~~src,startup: expose isolate_data even before env~~ src,bootstrap: expose isolate_data even before env Mar 15, 2025

jazelly force-pushed the expose-isolate-data branch from 4c9445f to f4643b9 Compare March 15, 2025 05:32

jazelly mentioned this pull request Mar 15, 2025

src: support (de)serialization of DOMException #57372

Draft

jazelly added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 16, 2025

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 16, 2025

legendecas reviewed Mar 17, 2025

View reviewed changes

src/node.h Outdated Show resolved Hide resolved

jazelly added blocked PRs that are blocked by other issues or PRs. and removed blocked PRs that are blocked by other issues or PRs. labels Mar 19, 2025

jazelly force-pushed the expose-isolate-data branch from f4643b9 to 0b6c017 Compare March 24, 2025 20:47

jazelly changed the title ~~src,bootstrap: expose isolate_data even before env~~ src: initialize privateSymbols for per_context Mar 24, 2025

jazelly force-pushed the expose-isolate-data branch from 0b6c017 to 22cdade Compare March 24, 2025 20:57

legendecas reviewed Mar 25, 2025

View reviewed changes

src/api/environment.cc Show resolved Hide resolved

src: initialize privateSymbols for per_context

e518bf4

jazelly force-pushed the expose-isolate-data branch from 22cdade to e518bf4 Compare March 25, 2025 12:01

legendecas reviewed Mar 25, 2025

View reviewed changes

src/api/environment.cc Show resolved Hide resolved

jazelly added 2 commits March 26, 2025 09:04

fix: MessagePort::MoveToContext crash

1b534a7

fix: check isolate_data when InitializePrivateSymbols

3a8ab2c

legendecas approved these changes Mar 26, 2025

View reviewed changes

src/api/environment.cc Outdated Show resolved Hide resolved

maybe local for initialize

40c0219

jazelly added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 27, 2025

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 1, 2025

aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Apr 6, 2025

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 6, 2025

nodejs-github-bot merged commit 79eddc6 into nodejs:main Apr 6, 2025
75 checks passed

JonasBa pushed a commit to JonasBa/node that referenced this pull request Apr 11, 2025

src: initialize privateSymbols for per_context

941c841

PR-URL: nodejs#57479 Reviewed-By: Chengzhong Wu <[email protected]>

RafaelGSS pushed a commit that referenced this pull request May 1, 2025

src: initialize privateSymbols for per_context

496a3cb

PR-URL: #57479 Reviewed-By: Chengzhong Wu <[email protected]>

RafaelGSS mentioned this pull request May 1, 2025

2025-05-06, Version 24.0.0 (Current) #57609

Merged

RafaelGSS pushed a commit that referenced this pull request May 2, 2025

src: initialize privateSymbols for per_context

3ff37a8

PR-URL: #57479 Reviewed-By: Chengzhong Wu <[email protected]>

aduh95 added the backport-requested-v22.x PRs awaiting manual backport to the v22.x-staging branch. label May 6, 2025

jazelly added a commit to jazelly/node that referenced this pull request May 7, 2025

src: initialize privateSymbols for per_context

cdf85d6

PR-URL: nodejs#57479 Reviewed-By: Chengzhong Wu <[email protected]>

jazelly mentioned this pull request May 7, 2025

[v22.x backport] src: initialize privateSymbols for per_context #58217

Closed

jazelly added a commit to jazelly/node that referenced this pull request May 10, 2025

src: initialize privateSymbols for per_context

51caf5f

PR-URL: nodejs#57479 Reviewed-By: Chengzhong Wu <[email protected]>

jazelly added a commit to jazelly/node that referenced this pull request May 16, 2025

src: initialize privateSymbols for per_context

62ff33e

PR-URL: nodejs#57479 Reviewed-By: Chengzhong Wu <[email protected]>

jazelly added a commit to jazelly/node that referenced this pull request May 17, 2025

src: initialize privateSymbols for per_context

e611888

PR-URL: nodejs#57479 Reviewed-By: Chengzhong Wu <[email protected]>

jazelly added a commit to jazelly/node that referenced this pull request May 17, 2025

src: initialize privateSymbols for per_context

1e5c8a2

PR-URL: nodejs#57479 Reviewed-By: Chengzhong Wu <[email protected]>

aduh95 pushed a commit to jazelly/node that referenced this pull request May 17, 2025

src: initialize privateSymbols for per_context

74e7d26

PR-URL: nodejs#57479 Reviewed-By: Chengzhong Wu <[email protected]>

aduh95 pushed a commit to jazelly/node that referenced this pull request May 17, 2025

src: initialize privateSymbols for per_context

f70bbaa

PR-URL: nodejs#57479 Reviewed-By: Chengzhong Wu <[email protected]>

aduh95 pushed a commit to jazelly/node that referenced this pull request May 17, 2025

src: initialize privateSymbols for per_context

ec65839

PR-URL: nodejs#57479 Backport-PR-URL: nodejs#58217 Reviewed-By: Chengzhong Wu <[email protected]>

aduh95 pushed a commit to jazelly/node that referenced this pull request May 18, 2025

src: initialize privateSymbols for per_context

1af7dd2

PR-URL: nodejs#57479 Reviewed-By: Chengzhong Wu <[email protected]>

aduh95 pushed a commit that referenced this pull request May 19, 2025

src: initialize privateSymbols for per_context

a376d10

PR-URL: #57479 Reviewed-By: Chengzhong Wu <[email protected]>

github-actions bot mentioned this pull request May 19, 2025

2025-05-21, Version 22.16.0 'Jod' (LTS) #58388

Merged

aduh95 pushed a commit that referenced this pull request May 19, 2025

src: initialize privateSymbols for per_context

4c5555d

PR-URL: #57479 Reviewed-By: Chengzhong Wu <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

src: initialize privateSymbols for per_context #57479

src: initialize privateSymbols for per_context #57479

Uh oh!

jazelly commented Mar 15, 2025 •

edited

Loading

Uh oh!

nodejs-github-bot commented Mar 15, 2025

Uh oh!

codecov bot commented Mar 15, 2025 •

edited

Loading

Uh oh!

nodejs-github-bot commented Mar 16, 2025

Uh oh!

nodejs-github-bot commented Mar 17, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

legendecas left a comment

Uh oh!

Uh oh!

Uh oh!

nodejs-github-bot commented Apr 6, 2025

Uh oh!

aduh95 commented May 6, 2025

Uh oh!

jazelly commented May 7, 2025

Uh oh!

aduh95 commented May 7, 2025

Uh oh!

Uh oh!

Uh oh!

src: initialize privateSymbols for per_context #57479

src: initialize privateSymbols for per_context #57479

Uh oh!

Conversation

jazelly commented Mar 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Mar 15, 2025

Uh oh!

codecov bot commented Mar 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

nodejs-github-bot commented Mar 16, 2025

Uh oh!

nodejs-github-bot commented Mar 17, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

legendecas left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

nodejs-github-bot commented Apr 6, 2025

Uh oh!

aduh95 commented May 6, 2025

Uh oh!

jazelly commented May 7, 2025

Uh oh!

aduh95 commented May 7, 2025

Uh oh!

Uh oh!

jazelly commented Mar 15, 2025 •

edited

Loading

codecov bot commented Mar 15, 2025 •

edited

Loading