test: make eval snapshot comparison more flexible #57020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #57020 +/- ##
==========================================
- Coverage 89.12% 89.10% -0.02%
==========================================
Files 665 665
Lines 193191 193193 +2
Branches 37213 37207 -6
==========================================
- Hits 172175 172146 -29
- Misses 13757 13770 +13
- Partials 7259 7277 +18 |
github-actions
bot
removed
the
request-ci
lpinca
approved these changes
Feb 13, 2025
lpinca
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in ee8939c |
acidiney
pushed a commit
to acidiney/node
that referenced
this pull request
Feb 23, 2025
PR-URL: nodejs#57020 Reviewed-By: Luigi Pinca <[email protected]>
targos
pushed a commit
that referenced
this pull request
Feb 24, 2025
PR-URL: #57020 Reviewed-By: Luigi Pinca <[email protected]>
targos
pushed a commit
that referenced
this pull request
Feb 25, 2025
PR-URL: #57020 Reviewed-By: Luigi Pinca <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 1, 2025
PR-URL: #57020 Reviewed-By: Luigi Pinca <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 1, 2025
PR-URL: #57020 Reviewed-By: Luigi Pinca <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Apr 2, 2025
PR-URL: #57020 Reviewed-By: Luigi Pinca <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Apr 3, 2025
PR-URL: #57020 Reviewed-By: Luigi Pinca <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 16, 2025
PR-URL: #57020 Reviewed-By: Luigi Pinca <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 17, 2025
PR-URL: #57020 Reviewed-By: Luigi Pinca <[email protected]>
codebytere
added a commit
to electron/electron
that referenced
this pull request
Apr 25, 2025
codebytere
added a commit
to electron/electron
that referenced
this pull request
Apr 25, 2025
RafaelGSS
pushed a commit
that referenced
this pull request
May 1, 2025
PR-URL: #57020 Reviewed-By: Luigi Pinca <[email protected]>
codebytere
added a commit
to electron/electron
that referenced
this pull request
May 1, 2025
RafaelGSS
pushed a commit
that referenced
this pull request
May 2, 2025
PR-URL: #57020 Reviewed-By: Luigi Pinca <[email protected]>
codebytere
added a commit
to electron/electron
that referenced
this pull request
May 5, 2025
* chore: bump node in DEPS to v22.15.0 * inspector: fix GN build nodejs/node#56798 * test: search cctest files nodejs/node#56791 * crypto: fix missing OPENSSL_NO_ENGINE guard nodejs/node#57012 * test,crypto: make tests work for BoringSSL nodejs/node#57021 * module: use synchronous hooks for preparsing in import(cjs) nodejs/node#55698 * deps: update simdjson to 3.12.0 nodejs/node#56874 * build: remove explicit linker call to libm on macOS nodejs/node#56901 * test: make eval snapshot comparison more flexible nodejs/node#57020 * src: allow embedder customization of OOMErrorHandler nodejs/node#57325 * src: do not pass nullptr to std::string ctor nodejs/node#57354 * src: lock the isolate properly in IsolateData destructor nodejs/node#57031 * chore: shrink --trace-atomics-wait patch * chore: fixup patch indices * build: fix GN build failure nodejs/node#57013 * crypto: expose security levels nodejs/node#56601 * zlib: add zstd support nodejs/node#52100 * test: move crypto related common utilities in common/crypto nodejs/node#56714 * cli: move --trace-atomics-wait to eol nodejs/node#52747 * test: disable test-https-client-renegotiation-limit BoringSSL doesn't support caller-initiated renegotiation - see https://source.chromium.org/chromium/chromium/src/+/main:third_party/boringssl/src/ssl/ssl_lib.cc;l=1627-1631 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <[email protected]>
codebytere
added a commit
to electron/electron
that referenced
this pull request
May 5, 2025
codebytere
added a commit
to electron/electron
that referenced
this pull request
May 6, 2025
codebytere
added a commit
to electron/electron
that referenced
this pull request
May 6, 2025
* chore: bump node in DEPS to v22.15.0 * inspector: fix GN build nodejs/node#56798 * test: search cctest files nodejs/node#56791 * crypto: fix missing OPENSSL_NO_ENGINE guard nodejs/node#57012 * test,crypto: make tests work for BoringSSL nodejs/node#57021 * module: use synchronous hooks for preparsing in import(cjs) nodejs/node#55698 * deps: update simdjson to 3.12.0 nodejs/node#56874 * build: remove explicit linker call to libm on macOS nodejs/node#56901 * test: make eval snapshot comparison more flexible nodejs/node#57020 * src: allow embedder customization of OOMErrorHandler nodejs/node#57325 * src: do not pass nullptr to std::string ctor nodejs/node#57354 * src: lock the isolate properly in IsolateData destructor nodejs/node#57031 * chore: shrink --trace-atomics-wait patch * chore: fixup patch indices * build: fix GN build failure nodejs/node#57013 * crypto: expose security levels nodejs/node#56601 * zlib: add zstd support nodejs/node#52100 * test: move crypto related common utilities in common/crypto nodejs/node#56714 * cli: move --trace-atomics-wait to eol nodejs/node#52747 * test: disable test-https-client-renegotiation-limit BoringSSL doesn't support caller-initiated renegotiation - see https://source.chromium.org/chromium/chromium/src/+/main:third_party/boringssl/src/ssl/ssl_lib.cc;l=1627-1631 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <[email protected]>
codebytere
added a commit
to electron/electron
that referenced
this pull request
May 7, 2025
deepak1556
pushed a commit
to electron/electron
that referenced
this pull request
May 13, 2025
* chore: bump node in DEPS to v22.15.0 * inspector: fix GN build nodejs/node#56798 * test: search cctest files nodejs/node#56791 * crypto: fix missing OPENSSL_NO_ENGINE guard nodejs/node#57012 * test,crypto: make tests work for BoringSSL nodejs/node#57021 * module: use synchronous hooks for preparsing in import(cjs) nodejs/node#55698 * deps: update simdjson to 3.12.0 nodejs/node#56874 * build: remove explicit linker call to libm on macOS nodejs/node#56901 * test: make eval snapshot comparison more flexible nodejs/node#57020 * src: allow embedder customization of OOMErrorHandler nodejs/node#57325 * src: do not pass nullptr to std::string ctor nodejs/node#57354 * build: fix GN build failure * build: fix patch indices * crypto: expose security levels nodejs/node#56601 * zlib: add zstd support nodejs/node#52100 * test: move crypto related common utilities in common/crypto nodejs/node#56714 * test: disable test-https-client-renegotiation-limit BoringSSL doesn't support caller-initiated renegotiation - see https://source.chromium.org/chromium/chromium/src/+/main:third_party/boringssl/src/ssl/ssl_lib.cc;l=1627-1631 * chore: fixup indices --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same approach as in #55401 - allows Electron to run Node.js' smoke tests.