streamResetBurst and streamResetRate options are missing in the documentation of http2.createSecureServer #57169
Comments
|
Is this open to work on? |
Sujal-Raj
added a commit
to Sujal-Raj/node
that referenced
this issue
Feb 26, 2025
Added missing documentation for the streamResetBurst and streamResetRate options in the http2.createSecureServer section. This ensures developers are aware of these configurable options. Fixes: nodejs#57169 Refs: https://nodejs.org/docs/latest/api/http2.html#http2createserveroptions-onrequesthandler
Sujal-Raj
added a commit
to Sujal-Raj/node
that referenced
this issue
Feb 26, 2025
Added missing documentation for the streamResetBurst and streamResetRate options in the http2.createSecureServer section. This ensures developers are aware of these configurable options. Fixes: nodejs#57169 Refs: https://nodejs.org/docs/latest/api/http2.html#http2createserveroptions-onrequesthandler
|
Note that this merge request did not resolve the wrong typings. I guess I will create another bug for this. |
aduh95
pushed a commit
that referenced
this issue
Mar 9, 2025
Added missing documentation for the streamResetBurst and streamResetRate options in the http2.createSecureServer section. This ensures developers are aware of these configurable options. Fixes: #57169 Refs: https://nodejs.org/docs/latest/api/http2.html#http2createserveroptions-onrequesthandler PR-URL: #57195 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tim Perry <[email protected]>
RafaelGSS
pushed a commit
that referenced
this issue
Apr 1, 2025
Added missing documentation for the streamResetBurst and streamResetRate options in the http2.createSecureServer section. This ensures developers are aware of these configurable options. Fixes: #57169 Refs: https://nodejs.org/docs/latest/api/http2.html#http2createserveroptions-onrequesthandler PR-URL: #57195 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tim Perry <[email protected]>
RafaelGSS
pushed a commit
that referenced
this issue
Apr 1, 2025
Added missing documentation for the streamResetBurst and streamResetRate options in the http2.createSecureServer section. This ensures developers are aware of these configurable options. Fixes: #57169 Refs: https://nodejs.org/docs/latest/api/http2.html#http2createserveroptions-onrequesthandler PR-URL: #57195 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tim Perry <[email protected]>
aduh95
pushed a commit
that referenced
this issue
Apr 2, 2025
Added missing documentation for the streamResetBurst and streamResetRate options in the http2.createSecureServer section. This ensures developers are aware of these configurable options. Fixes: #57169 Refs: https://nodejs.org/docs/latest/api/http2.html#http2createserveroptions-onrequesthandler PR-URL: #57195 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tim Perry <[email protected]>
aduh95
pushed a commit
that referenced
this issue
Apr 3, 2025
Added missing documentation for the streamResetBurst and streamResetRate options in the http2.createSecureServer section. This ensures developers are aware of these configurable options. Fixes: #57169 Refs: https://nodejs.org/docs/latest/api/http2.html#http2createserveroptions-onrequesthandler PR-URL: #57195 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tim Perry <[email protected]>
RafaelGSS
pushed a commit
that referenced
this issue
Apr 16, 2025
Added missing documentation for the streamResetBurst and streamResetRate options in the http2.createSecureServer section. This ensures developers are aware of these configurable options. Fixes: #57169 Refs: https://nodejs.org/docs/latest/api/http2.html#http2createserveroptions-onrequesthandler PR-URL: #57195 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tim Perry <[email protected]>
RafaelGSS
pushed a commit
that referenced
this issue
Apr 17, 2025
Added missing documentation for the streamResetBurst and streamResetRate options in the http2.createSecureServer section. This ensures developers are aware of these configurable options. Fixes: #57169 Refs: https://nodejs.org/docs/latest/api/http2.html#http2createserveroptions-onrequesthandler PR-URL: #57195 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tim Perry <[email protected]>
RafaelGSS
pushed a commit
that referenced
this issue
May 1, 2025
Added missing documentation for the streamResetBurst and streamResetRate options in the http2.createSecureServer section. This ensures developers are aware of these configurable options. Fixes: #57169 Refs: https://nodejs.org/docs/latest/api/http2.html#http2createserveroptions-onrequesthandler PR-URL: #57195 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tim Perry <[email protected]>
RafaelGSS
pushed a commit
that referenced
this issue
May 2, 2025
Added missing documentation for the streamResetBurst and streamResetRate options in the http2.createSecureServer section. This ensures developers are aware of these configurable options. Fixes: #57169 Refs: https://nodejs.org/docs/latest/api/http2.html#http2createserveroptions-onrequesthandler PR-URL: #57195 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tim Perry <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Affected URL(s)
https://nodejs.org/docs/latest/api/http2.html#http2createsecureserveroptions-onrequesthandler
Description of the problem
The new options were added in Node 18.18.2, 20.8.1 und 21.0 to mitigate RST attacks.
It is documented for http2.createServer, but missing in http2.createSecureServer.
I am pretty sure it works for both, because the way createServer and createSecureServer share the code handling the options. It also makes absolutely no sense for them to work for createServer and not for createSecureServer.
The Typescript typings are also wrong. Only createServer typings recognizes streamResetBurst and streamResetRate. If I want to use them for createSecureServer, i have to supress typescript errors for this line and then it seems to work.
The text was updated successfully, but these errors were encountered: