Skip to content

Enable CFG in node.exe #42100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ahtrahdis7 opened this issue Feb 23, 2022 · 5 comments · Fixed by #56605
Closed

Enable CFG in node.exe #42100

ahtrahdis7 opened this issue Feb 23, 2022 · 5 comments · Fixed by #56605
Labels
build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform.

Comments

@ahtrahdis7
Copy link

BinSkim is a binary static analysis tool that provides security and correctness results for Windows Portable Executable and *nix ELF binary formats.

  • Browser : N/A
  • OS: Windows 8

error BA2008: 'node.exe' does not enable the control flow guard (CFG) mitigation. To resolve this issue, pass /guard:cf on both the compiler and linker command lines. Binaries also require the /DYNAMICBASE linker option in order to enable CFG.

Screenshot 2022-02-23 at 6 17 17 PM

Package used : https://github.com/microsoft/binskim
Command used : .\BinSkim.exe analyze < path to executable >
@nschonni

This comment was marked as resolved.

Sign in to view
@Trott Trott transferred this issue from nodejs/nodejs.org Feb 23, 2022
@Trott Trott changed the title BinSkim Security Analysis Enable CFG in node.exe Feb 23, 2022
@Mesteery Mesteery added build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform. labels Feb 23, 2022
@richardlau
Copy link
Member

cc @nodejs/platform-windows

@ahtrahdis7
Copy link
Author

Please check for Linux and MacOS binaries also.

@Trott
Copy link
Member

Trott commented Feb 24, 2022

Please check for Linux and MacOS binaries also.

Control flow guard isn't a thing that exists on those platforms.

@ahtrahdis7
Copy link
Author

I meant to say, run the Mac and Linux binaries against BinSkim to generate their reports.

@ahtrahdis7 ahtrahdis7 mentioned this issue Feb 25, 2022
Closed
@huseyinacacak-janea huseyinacacak-janea mentioned this issue Jan 15, 2025
Merged
aduh95 pushed a commit that referenced this issue Mar 9, 2025
@huseyinacacak-janea @aduh95
win,build: add option to enable Control Flow Guard
b98b278 
PR-URL: #56605
Fixes: #42100
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
aduh95 pushed a commit that referenced this issue Mar 9, 2025
@huseyinacacak-janea @aduh95
win,build: add option to enable Control Flow Guard
17d4074 
PR-URL: #56605
Fixes: #42100
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
RafaelGSS pushed a commit that referenced this issue Apr 1, 2025
@huseyinacacak-janea @RafaelGSS
win,build: add option to enable Control Flow Guard
76212a1 
PR-URL: #56605
Fixes: #42100
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
RafaelGSS pushed a commit that referenced this issue Apr 1, 2025
@huseyinacacak-janea @RafaelGSS
win,build: add option to enable Control Flow Guard
2122888 
PR-URL: #56605
Fixes: #42100
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
aduh95 pushed a commit that referenced this issue Apr 2, 2025
@huseyinacacak-janea @aduh95
win,build: add option to enable Control Flow Guard
c4df92d 
PR-URL: #56605
Fixes: #42100
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
aduh95 pushed a commit that referenced this issue Apr 3, 2025
@huseyinacacak-janea @aduh95
win,build: add option to enable Control Flow Guard
fe992ef 
PR-URL: #56605
Fixes: #42100
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
RafaelGSS pushed a commit that referenced this issue Apr 16, 2025
@huseyinacacak-janea @RafaelGSS
win,build: add option to enable Control Flow Guard
36ebfd4 
PR-URL: #56605
Fixes: #42100
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
RafaelGSS pushed a commit that referenced this issue Apr 17, 2025
@huseyinacacak-janea @RafaelGSS
win,build: add option to enable Control Flow Guard
c06d218 
PR-URL: #56605
Fixes: #42100
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
RafaelGSS pushed a commit that referenced this issue May 1, 2025
@huseyinacacak-janea @RafaelGSS
win,build: add option to enable Control Flow Guard
8008f96 
PR-URL: #56605
Fixes: #42100
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
RafaelGSS pushed a commit that referenced this issue May 2, 2025
@huseyinacacak-janea @RafaelGSS
win,build: add option to enable Control Flow Guard
0ee6145 
PR-URL: #56605
Fixes: #42100
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

win,build: add option to enable cfg JaneaSystems/node
5 participants
@Trott @nschonni @richardlau @ahtrahdis7 @Mesteery