This repository was archived by the owner on Apr 22, 2023. It is now read-only.
test: make test-abort-fatal-error non flaky #25755
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is needed to land #25569. |
|
/cc @joyent/node-collaborators |
|
@misterdjules Commit message: you mention |
|
Tested on SmartOS, LGTM. |
misterdjules
force-pushed
the
make-abort-on-fatal-error-not-flaky
branch
from
76c69b3 to
d1ea245
Compare
Before this change, test/simple/test-abort-fatal-error.js would fail in some environments for reasons I wasn't able to fully understand. It was marked as flaky on some systems, but not on others on which it was failing sometimes (OSX). This change basically syncs test-abort-fatal-error with how it's implemented in v0.12. It back ports 429b587 (or rather the parts that apply to it since it's a merge commit), 2f5e77f and 114bff4. After backporting these changes in v0.10, test-abort-fatal-error is not flaky anymore in environments for which it was flaky. It also has the added benefit of being more robust because it checks exit codes and signals instead of error messages. Tested on OSX and SmartOS, the only platforms on which I could reproduce the flakiness of this test. This change also removes test-abort-fatal-error from the list of flaky tests in test/simple/simple.status. Fixes nodejs#25720.
misterdjules
force-pushed
the
make-abort-on-fatal-error-not-flaky
branch
from
d1ea245 to
a8e2a76
Compare
|
Good catch and thank you @joaocgreis 👍 Updated the commit message, will land asap. |
misterdjules
pushed a commit
to misterdjules/node
that referenced
this pull request
Jul 23, 2015
Before this change, test/simple/test-abort-fatal-error.js would fail in some environments for reasons I wasn't able to fully understand. It was marked as flaky on some systems, but not on others on which it was failing sometimes (OSX). This change basically syncs test-abort-fatal-error with how it's implemented in v0.12. It back ports 429b587 (or rather the parts that apply to it since it's a merge commit), 2f5e77f and 114bff4. After backporting these changes in v0.10, test-abort-fatal-error is not flaky anymore in environments for which it was flaky. It also has the added benefit of being more robust because it checks exit codes and signals instead of error messages. Tested on OSX and SmartOS, the only platforms on which I could reproduce the flakiness of this test. This change also removes test-abort-fatal-error from the list of flaky tests in test/simple/simple.status. Fixes nodejs#25720. PR: nodejs#25755 PR-URL: nodejs#25755 Reviewed-By: João Reis <[email protected]>
|
Landed in e10892c. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, test/simple/test-abort-fatal-error.js would fail in
some environments for reasons I wasn't able to fully understand. It was
marked as flaky on some systems, but not on others on which it was
failing sometimes (OSX).
This change basically syncs test-abort-fatal-error with how it's
implemented in v0.12. It back ports 429b587 (or rather the parts that
apply to it since it's a merge commit), 2f5e77f and 114bff4.
After backporting these changes in v0.10, test-abort-fatal-error is not
flaky anymore in environments for which it was flaky. It also has the
added benefit of being more robust because it checks exit codes and
signals instead of error messages.
Tested on OSX and SmartOS, the only platforms on which I could reproduce
the flakiness of this test.
This change also removes test-abort-fatal-error from the list of flaky
tests in test/simple/simple.status.
Fixes #25720.