-
-
Notifications
You must be signed in to change notification settings - Fork 173
Dialog & all its inherited widget added #344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- FileDialog - InputDialog - ProgressDialog Edited: - demo file for testing the dialogs
- ColorDialog - FontDialog Edited: - Dialog (for adding some props)
Amazing work!!!
Can you add a warning log here saying child wasnt rendered because it was used not inside a view or boxview when this happens ? |
Currently I don't know any way of accessing parent Component/Widget in react thus determining whether any component was added as a child to a certain type of Component/s isn't possible in that view. But if there's any |
You can take a look at this: https://github.com/nodegui/react-nodegui/blob/master/src/components/TabItem/RNTabItem.ts But If its too complex for this use case we can go ahead with too. |
Well, I looked into that example.. But I've to extend Looks like it'd be complicated for the react-nodegui part. So I suggest about going ahead |
@all-contributors add @KRTirtho for code |
I've put up a pull request to add @KRTirtho! 🎉 |
Fixes #108
Added Components:
Edited/Modified:
NodeDialog
inherited widgets)Disclaimer!:
Dialog
& its all inherited widgets can only be used inside aView
orBoxView
. Using it in other places will not work. It'd cause the Dialog components to not appear. This behavior was expected since addingNodeDialog
inherited widgets to Layout or as a child to other widgets doesn't work. Thus filters were added toView
&BoxView
to not let anyinstance
ofNodeDialog
to be added in the layout treeAn working example:
Thanks @a7ul