Skip to content

Remove 'usedefault' from gm_odf & csf_odf in mrtrix3.EstimateFOD input spec #3190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

tclose
Copy link
Contributor

@tclose tclose commented Mar 18, 2020

Summary

Was not able to use original (non-multi tissue) CSD algorithm to estimate fibre orientation distributions as the unexpected (for single-tissue reconstruction) output gm-odf and csf-odf files were being written to the command line.

Fixes # .

List of changes proposed in this PR (pull-request)

  • removed 'usedefault=True' from gm_odf & csf_odf traits of mrtrix3.EstimateFOD input spec
  • added .vscode and .history to gitignore

Acknowledgment

  • [ x ] (Mandatory) I acknowledge that this contribution will be available under the Apache 2 license.

@codecov
Copy link

codecov bot commented Mar 18, 2020

Codecov Report

Merging #3190 into master will increase coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3190      +/-   ##
==========================================
+ Coverage   65.07%   65.21%   +0.13%     
==========================================
  Files         301      301              
  Lines       39584    39895     +311     
  Branches     5229     5340     +111     
==========================================
+ Hits        25759    26016     +257     
- Misses      12764    12818      +54     
  Partials     1061     1061              
Flag Coverage Δ
#unittests 65.21% <ø> (+0.13%) ⬆️
Impacted Files Coverage Δ
nipype/interfaces/mrtrix3/reconst.py 81.48% <ø> (ø)
nipype/pipeline/plugins/legacymultiproc.py 65.34% <0.00%> (-3.47%) ⬇️
nipype/pipeline/plugins/base.py 62.46% <0.00%> (-1.65%) ⬇️
nipype/interfaces/ants/segmentation.py 77.14% <0.00%> (+0.04%) ⬆️
nipype/pipeline/engine/workflows.py 74.34% <0.00%> (+5.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2a5c4b...6ea0504. Read the comment docs.

@effigies
Copy link
Member

This should be resolved by the addition of a new interface. Can you check the docs? Otherwise I can find the PR in a bit.

@tclose
Copy link
Contributor Author

tclose commented Mar 18, 2020

I don't see any new interfaces that look relevant in the docs. Also searched the master branch for 'dwi2fod' and it only came up with the EstimateFOD

@effigies
Copy link
Member

#3176

@tclose
Copy link
Contributor Author

tclose commented Mar 18, 2020

Ok, thanks

@tclose tclose closed this Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants