ENH: Minimize the number of calls to _load_results when populating inputs
#3075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g inputs This PR attempts to alleviate nipy#3014 by opening the result file of a source node only once when that node feeds into several inputs of the node collecting inputs. Before these changes, a call to ``_load_results`` was issued for every input field that needed to collect its inputs from a past node. Now, all the inputs comming from the same node are put together and the ``_load_results`` function is called just once. The PR also modifies the manner the ``AttributeError``s (nipy#3014) were handled to make it easier to spot whether an error occured while loading results araises when gathering the inputs of a node-to-be-run or elsewhere.
oesteban
commented
Oct 11, 2019
Codecov Report
@@ Coverage Diff @@
## master #3075 +/- ##
==========================================
- Coverage 68.19% 64.56% -3.64%
==========================================
Files 297 295 -2
Lines 39770 39691 -79
Branches 5209 5202 -7
==========================================
- Hits 27122 25627 -1495
- Misses 11939 13018 +1079
- Partials 709 1046 +337
Continue to review full report at Codecov.
|
|
I'm going to give it a quick try locally with fMRIPrep before merging in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to alleviate #3014 by opening the result file of a source node only once when that node feeds into several inputs of the node collecting inputs. Before these changes, a call to
_load_resultswas issued for every input field that needed to collect its inputs from a past node. Now, all the inputs coming from the same node are put together and the_load_resultsfunction is called just once.The PR also modifies the manner the
AttributeErrors (#3014) were handled to make it easier to spot whether an error occurred while loading results araises when gathering the inputs of a node-to-be-run or elsewhere.