PR: FIX Check that file exists in basedir, not current dir #2945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oesteban
reviewed
Jun 19, 2019
| @@ -486,7 +486,7 @@ def modify_paths(object, relative=True, basedir=None): | |||
| out = tuple(out) | |||
| else: | |||
| if isdefined(object): | |||
| if isinstance(object, (str, bytes)) and os.path.isfile(object): | |||
| if isinstance(object, (str, bytes)) and os.path.isfile(os.path.join(basedir, object)): | |||
There was a problem hiding this comment.
Please dismiss this comment.
Please check whether this:
Suggested change
| if isinstance(object, (str, bytes)) and os.path.isfile(os.path.join(basedir, object)): | |
| if isinstance(object, (str, bytes)) and os.path.isfile(os.path.join(basedir, os.path.basename(object))): |
Does not bring us back to the original problem. My impression is that it will. I agree with @effigies this is a result of loosing track of the traits.
Codecov Report
@@ Coverage Diff @@
## master #2945 +/- ##
=======================================
Coverage 67.59% 67.59%
=======================================
Files 344 344
Lines 43747 43747
Branches 5456 5456
=======================================
Hits 29572 29572
+ Misses 13466 13458 -8
- Partials 709 717 +8
Continue to review full report at Codecov.
|
oesteban
added a commit
to oesteban/nipype
that referenced
this pull request
Aug 1, 2019
Once we figure out the problem of ``OutputMultiObject``, we could go ahead and set fix nipy#2944, fix nipreps/fmriprep#1674, close nipy#2945.
oesteban
added a commit
to oesteban/nipype
that referenced
this pull request
Aug 1, 2019
Once we figure out the problem of ``OutputMultiObject``, we could go ahead and set fix nipy#2944, fix nipreps/fmriprep#1674, close nipy#2945.
oesteban
added a commit
to oesteban/nipype
that referenced
this pull request
Aug 2, 2019
Once we figure out the problem of ``OutputMultiObject``, we could go ahead and set fix nipy#2944, fix nipreps/fmriprep#1674, close nipy#2945.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2944
List of changes proposed in this PR (pull-request)
Acknowledgment